Odd shutdown/timeshift interaction when not using timeshift

[birdman]

There's an oddity between Deep Standby code and Timeshift code.

A workaround for the issue is this:

http://www.world-of-satellite.com/sh...929#post382929

This is a thread to try to sort out an actual solution.

Basically the problem (I think) is this in Components/Timeshift.py (line 1248):

# Restart FrontPanel LED when still copying or merging files
# ToDo: Only do this on PTS Events and not events from other           jobs
if timer.state == TimerEntry.StateEnded and (len(JobManager.getPendingJobs()) > 1 or self.pts_mergeRecords_timer.isActive()):
        self.ptsFrontpanelActions("start")
        config.timeshift.isRecording.value = True

The ToDo hasn't been done. So when get to this code (ptsTimerEntryStateChange()) during shut-down at the end of a recording and happen to have config.timeshift.stopwhilerecoding set to True then even if you've never had timeshift running you drop into this code and the rest of the shutdown code reckons you have a recording running.