EPG files test: Phase 1. Refactor

[abu baniaz]

Thanks for the reproduction step. I don't normally activate it that way, but will start using it for the test. May even make its way into the navigation guide. I can confirm crash too.

Press up to invoke Channel list, select any channel, Press Info or GUIDE, results in a crash

< 69649.151> [InfoBarGenerics] KEY: 358 INFO
< 69649.151> [ActionMap] Keymap 'ChannelSelectEPGActions' -> Unknown action 'info'! (Typo in keymap?)
< 69649.151> [ActionMap] Keymap 'ChannelSelectEPGActions' -> Action = 'showEPGList'.
< 69649.153> Traceback (most recent call last):
< 69649.153>   File "/usr/lib/enigma2/python/Components/ActionMap.py", line 57, in action
< 69649.153>   File "/usr/lib/enigma2/python/Screens/ChannelSelection.py", line 946, in showEPGList
< 69649.153>   File "/usr/lib/enigma2/python/mytest.py", line 329, in openWithCallback
< 69649.153>     dlg = self.open(screen, *arguments, **kwargs)
< 69649.153>   File "/usr/lib/enigma2/python/mytest.py", line 339, in open
< 69649.154>     dlg = self.current_dialog = self.instantiateDialog(screen, *arguments, **kwargs)
< 69649.154>   File "/usr/lib/enigma2/python/mytest.py", line 276, in instantiateDialog
< 69649.154>     return self.doInstantiateDialog(screen, arguments, kwargs, self.desktop)
< 69649.154>   File "/usr/lib/enigma2/python/mytest.py", line 299, in doInstantiateDialog
< 69649.154>     dlg = screen(self, *arguments, **kwargs)
< 69649.154> TypeError: __init__() got an unexpected keyword argument 'serviceChangeCB'
< 69649.154> [ePyObject] (CallObject(<bound method ActionMap.action of <Components.ActionMap.ActionMap instance at 0xb0b481c0>>,('ChannelSelectEPGActions', 'showEPGList')) failed

EDIT:
Fixed here: https://github.com/SimonCapewell/eni...c9f27c666590f8

[simonc]

Thanks for those 2. I've got fixes on the way for them

[abu baniaz]

The two crashes have been fixed. Thanks Simon. I have edited posts above with links to fixes. I have uploaded the attachment in post 1. Hopefully without errors. If you have tested previous files, please delete the older Epg folders first. Otherwise redundant files will remain.

Thank you for your continued tests, feedback and assistance.

[ronand]

Those fixes seem to have worked. However I've spotted something else when using EPG Search - The channel name is now transposed over the satellite position as in the attached image. The skin is Magic FHD but I dont think that is the issue as it works fine on the regular 5.3.020 build

Attachment 59889

Mod EDIT
Fixed here. Thanks for reporting
https://github.com/SimonCapewell/eni...723633a92dda8f

[bbbuk]

I have same as mentioned by @Ronand

Even though I didn't think it was related to skin, I did try two different skins. Same thing....

Attachment 59890

[simonc]

Another bug squashed :-)

[abu baniaz]

This is the modified file to fix the overlap. I'll upload the attachemnt inpost 1 to include it.

[abu baniaz]

Another bug squashed :-)

That has introduced another.

Steps:
EPG/Guide to invoke Grid EPG (Graphics)
Yellow for EPG search

<  9926.369> [EPGSelectionGrid] ------- NEW VERSION -------
<  9926.370> [EPGSelectionBase] 5
<  9926.373> [EPGListGrid] Init
<  9926.373> [EPGListBase] Init
<  9926.379> [Skin] Processing screen 'GraphicalEPGPIG' from list 'GridEPGPIG, GraphicalEPGPIG', position=(0, 0), size=(1280 x 720) for module 'EPGSelectionGrid'.
<  9926.394> [GUISkin] warning, skin is missing element number in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.395> [GUISkin] warning, skin is missing element jump in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.396> [GUISkin] warning, skin is missing element page in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.396> [GUISkin] warning, skin is missing element primetime in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.396> [GUISkin] warning, skin is missing element timeline0 in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.396> [GUISkin] warning, skin is missing element timeline2 in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.396> [GUISkin] warning, skin is missing element timeline3 in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.396> [GUISkin] warning, skin is missing element timeline1 in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.396> [GUISkin] warning, skin is missing element timeline4 in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.397> [GUISkin] warning, skin is missing element timeline5 in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.398> [GUISkin] warning, skin is missing element change_bouquet in <class 'Screens.Epg.EpgSelectionGrid.EPGSelectionGrid'>
<  9926.410> [Skin] Processing screen 'GraphicalEPGPIG_summary' from list 'GridEPGPIG_summary, GraphicalEPGPIG_summary, SimpleSummary', position=(0, 0), size=(220 x 176) for module 'SimpleSummary'.
<  9927.821> [eInputDeviceInit] 1 190 1
<  9927.821> [InfoBarGenerics] KEY: 400 YELLOW
<  9928.020> [eInputDeviceInit] 0 190 1
<  9928.020> [InfoBarGenerics] KEY: 400 YELLOW
<  9928.020> [ActionMap] Keymap 'ColorActions' -> Action = 'yellow'.
<  9928.026> Traceback (most recent call last):
<  9928.026>   File "/usr/lib/enigma2/python/Components/ActionMap.py", line 57, in action
<  9928.026>   File "/usr/lib/enigma2/python/Screens/Epg/EpgSelectionBase.py", line 29, in fn
<  9928.026>     action()
<  9928.026>   File "/usr/lib/enigma2/python/Screens/Epg/EpgSelectionBase.py", line 202, in openEPGSearch
<  9928.026>     self.session.open(EPGSearch, name, False)
<  9928.026>   File "/usr/lib/enigma2/python/mytest.py", line 339, in open
<  9928.027>     dlg = self.current_dialog = self.instantiateDialog(screen, *arguments, **kwargs)
<  9928.027>   File "/usr/lib/enigma2/python/mytest.py", line 276, in instantiateDialog
<  9928.027>     return self.doInstantiateDialog(screen, arguments, kwargs, self.desktop)
<  9928.027>   File "/usr/lib/enigma2/python/mytest.py", line 299, in doInstantiateDialog
<  9928.027>     dlg = screen(self, *arguments, **kwargs)
<  9928.027>   File "/usr/lib/enigma2/python/Plugins/Extensions/EPGSearch/EPGSearch.py", line 238, in __init__
<  9928.027>   File "/usr/lib/enigma2/python/Plugins/Extensions/EPGSearch/EPGSearch.py", line 60, in __init__
<  9928.027>   File "/usr/lib/enigma2/python/Components/EpgList.py", line 39, in __init__
<  9928.027>     EPGListSingle.__init__(self, config.epgselection.single, selChangedCB, timer)
<  9928.027>   File "/usr/lib/enigma2/python/Components/config.py", line 1884, in __getattr__
<  9928.027> AttributeError: single
<  9928.028> [ePyObject] (CallObject(<bound method HelpableActionMap.action of <Components.ActionMap.HelpableActionMap instance at 0xafda92b0>>,('ColorActions', 'yellow')) failed)

EDIT @16:50:
Fixed here https://github.com/SimonCapewell/eni...a5c56faf301a57
Post 1 updated with newer files.

[simonc]

Bah! That's by the EPG naming and config cleanup task getting in the way. It's time to bite the bullet and commit those changes too, rather than continue to juggle things.

Just a warning that these updates include changes to setup.xml and menu.xml and will start using a new set of configuration values, so the new EPGs will use default settings. The old settings seem to be persisted so if you revert back to the current EPG, then things are still as you left them.

[bbbuk]

As it objects to use of 'single', if u revert just line 39 from epglist.py back to what it was, I've been able to get mine working again...

Attachment 59896

Looks okay (as in not overlap or even crashing). Don't know of any unintended consequence of that!

[abu baniaz]

Version 4 attached to first post. Please note the amended instructions with regards to the two xml files.

Sorry for the trouble and inconvenience. Thanks once again

[abu baniaz]

An quirk/oddity that may affect receivers that do not have EPG button and only the Info button.

EPG button to Invoke Grid EPG.
Info button invokes EventView'
EPG button invokes Single EPG

In channel selection screen, both buttons instigate Single EPG (the one that you can change services)

Note: I am testing with Vix Night HD

[dsayers]

In GraphicalEPG changing Service Title mode between "Picon, Service Number and Service Name" or "Service Number, Picon and Service Name" seems to always show Picon, Service Number and Service Name.

Same with "Service Number and Picon" or "Picon and Service Number" it always shows Picon and Service Number.

Mod Edit
Fixed with: https://github.com/SimonCapewell/eni...36dae34c90de77
Upload in post 1 contains fix

[ccs]

Up and running with the latest version (the one including the xml files).

So far so good, it took about 3 minutes to set up the box the same as I had previously configured it.

(FWIW it took me more than 3 hours to get the epg working on the box when starting from scratch last week. The epg/guide button insisted on taking make straight to "all channels", when I'd supposedly set it up to show bouquets on launch. Reboots, restarting GUI, waiting for the epg to populate, made no difference. And then, as if by magic, it started working.
I hope abu isn't reading this.)

[bbbuk]

Just updated to v4 and ok so far

@Abu you may wish to update post 1 to say some settings may need to be reset again