Help needed please with cron timer

[birdman]

I only ever save as ASCII/text unless it's already binary

If it were binary you wouldn't have opened it in TextWrangler...
But you still haven't mentioned how you get the file onto the box.

(i'm told it's the best editor for mac and the equivalent of notepad++)

I use a Unix text editor on the box itself...the same one I use on me desktop/laptop - and the same one I've used for the last 25+ years....

[grantdavey91]

If it were binary you wouldn't have opened it in TextWrangler...
But you still haven't mentioned how you get the file onto the box.

I use a Unix text editor on the box itself...the same one I use on me desktop/laptop - and the same one I've used for the last 25+ years....

yeah thats what i mean, if its binary i dont open it; just transfer to box

i get the files onto the box by ftp using filezilla

i wasn't even aware there was a unix editor built into enigma2! where's that? thanks

[birdman]

i wasn't even aware there was a unix editor built into enigma2! where's that? thanks

There appear to be three editors in the packages - joe, nano and vim. None is installed by default.

But I use an old, much modified version of microemacs that we used at work (it ran on every system we ever had). It's what Linus Torvalds uses, except he has a much later version that can handle utf-8 - perhaps one day I'll try to merge the sources....

[grantdavey91]

Hi, Birdman.

Sorry to bring this thread up again.

The same skin mod from the screenshot in page 1 has now been edited with two new shell scripts; and seems to be working again for everyone except those with vu boxes...

I have uploaded the two sh files, would you mind taking a look and adjust as necessary and send them back to me ?

I ran commands through telnet but just getting a bunch of (in my opinion) gibberish i cant get my head around :

telnet results :

Last login: Tue Sep 20 23:09:38 IST 2016 from 192.168.0.5 on pts/0
root@vuduo2:~# cd /usr/script
root@vuduo2:/usr/script# ./toppicks1.sh
-sh: ./toppicks1.sh: not found
root@vuduo2:/usr/script# ./topppicks1.sh
-sh: ./topppicks1.sh: not found
root@vuduo2:/usr/script# ./toppicks2.sh
-sh: ./toppicks2.sh: not found
root@vuduo2:/usr/script# /usr/script/toppicks1.sh
-sh: /usr/script/toppicks1.sh: not found
root@vuduo2:/usr/script# /bin/bash ./toppicks1.sh
: not found.sh: line 3: 
: not found.sh: line 5: 
./toppicks1.sh: line 88: syntax error: unexpected end of file (expecting "then")
root@vuduo2:/usr/script# /bin/bash ./toppicks1.sh
: not found.sh: line 3: 
: not found.sh: line 5: 
./toppicks1.sh: line 69: syntax error: unexpected end of file (expecting "then")
root@vuduo2:/usr/script# /bin/bash .toppicks1.sh
/bin/bash: can't open '.toppicks1.sh'
root@vuduo2:/usr/script# /bin/bash ./toppicks1.sh
: not found.sh: line 3: 
: not found.sh: line 5: 
./toppicks1.sh: line 69: syntax error: unexpected end of file
root@vuduo2:/usr/script# /bin/bash ./toppicks1.sh
: not found.sh: line 3: 
: not found.sh: line 5: 
./toppicks1.sh: line 69: syntax error: unexpected "done" (expecting "then")
root@vuduo2:/usr/script# ./toppicks1.sh
-sh: ./toppicks1.sh: not found
root@vuduo2:/usr/script# /bin/bash ./toppicks1.sh
: not found.sh: line 3: 
: not found.sh: line 5: 
./toppicks1.sh: line 70: syntax error: unexpected "done" (expecting "then")
root@vuduo2:/usr/script# /bin/bash ./toppicks1.sh
: not found.sh: line 3: 
: not found.sh: line 5: 
./toppicks1.sh: line 70: syntax error: unexpected ";"
root@vuduo2:/usr/script# /bin/bash ./toppicks1.sh
: not found.sh: line 3: 
: not found.sh: line 5: 
./toppicks1.sh: line 70: syntax error: unexpected ";"
root@vuduo2:/usr/script# /bin/bash ./toppicks1.sh
: not found.sh: line 3: 
: not found.sh: line 5: 
./toppicks1.sh: line 70: syntax error: unexpected "done"
root@vuduo2:/usr/script# /bin/bash ./toppicks1.sh
: not found.sh: line 3: 
: not found.sh: line 5: 
./toppicks1.sh: line 70: syntax error: unexpected end of file
root@vuduo2:/usr/script# /bin/bash ./toppicks2.sh
: not found.sh: line 3: 
: not found.sh: line 7: 
./toppicks2.sh: cd: line 8: can't cd to /usr/script/scrapes
: not found.sh: line 9: 
/premiere.png': No such file or directory-hd/toppicks/picons-base/
./toppicks2.sh: line 12: can't open new.txt: no such file
./toppicks2.sh: line 13: arithmetic syntax error
root@vuduo2:/usr/script#

as you can see i tried to play around with it a bit but had no such luck

attached .sh files are default releases and unchanged; if you can find the error as with the last script, would be greatly appreciated

many thanks in advance

[dsayers]

what happens when using script runner? can you ftp extention create a folder call it what you want ie updatetoppicks then creat a file called plugin.py inside the plugin.py paste these contents

from Plugins.Plugin import PluginDescriptor
from os import system


def main(session, **kwargs):
       system('/usr/script/toppicks1.sh &')
 






###########################################################################




def Plugins(**kwargs):
        return PluginDescriptor(
                name="Update Toppics",
                description="Update Toppicks files for slyk1hd",
                where = PluginDescriptor.WHERE_PLUGINMENU,
                fnc=main)

add another file called __init__.py leave it blank

ensure the script is in usr/script

reboot box and see if you can run the plugin

[grantdavey91]

what happens when using script runner? can you ftp extention create a folder call it what you want ie updatetoppicks then creat a file called plugin.py inside the plugin.py paste these contents

from Plugins.Plugin import PluginDescriptor
from os import system


def main(session, **kwargs):
       system('/usr/script/toppicks1.sh &')
 






###########################################################################




def Plugins(**kwargs):
        return PluginDescriptor(
                name="Update Toppics",
                description="Update Toppicks files for slyk1hd",
                where = PluginDescriptor.WHERE_PLUGINMENU,
                fnc=main)

add another file called __init__.py leave it blank

ensure the script is in usr/script

reboot box and see if you can run the plugin

thanks for the reply dsayers , ran script runner but i just get 'unexpected end of file'

[birdman]

what happens when using script runner?

With errors like those reported it's not going to run anywhere.

root@vuduo2:/usr/script# ./toppicks1.sh
-sh: ./toppicks1.sh: not found

That, for instance, means that ./toppicks.sh exists and the OS start to run it. It reads the first line (#!/bin/sh) and since that starts with #!, /bin/sh is invoked as the interpreter and passed the script name. But sh can't find that file - despite the fact that it must have been there in order to get to that point!?!

Everything about it seems to indicate to me that the script has been somehow garbled in being copied.

grantdavey9, run:

od -c ./toppicks1.sh

and paste the first twenty lines or so here.

[grantdavey91]

With errors like those reported it's not going to run anywhere.

root@vuduo2:/usr/script# ./toppicks1.sh
-sh: ./toppicks1.sh: not found

That, for instance, means that ./toppicks.sh exists and the OS start to run it. It reads the first line (#!/bin/sh) and since that starts with #!, /bin/sh is invoked as the interpreter and passed the script name. But sh can't find that file - despite the fact that it must have been there in order to get to that point!?!

Everything about it seems to indicate to me that the script has been somehow garbled in being copied.

grantdavey9, run:

od -c ./toppicks1.sh

and paste the first twenty lines or so here.

thanks for the reply birdman

ran the command, here's the 1st 30 lines :

root@vuduo2:/usr/script# od -c ./toppicks1.sh
0000000    #   !   /   b   i   n   /   s   h  \r  \n   #  \r  \n  \r  \n
0000020    u   n   s   e   t       L   D   _   P   R   E   L   O   A   D
0000040   \r  \n  \r  \n   w   o   r   k   d   i   r   =   /   u   s   r
0000060    /   s   c   r   i   p   t   /   s   c   r   a   p   e   s  \r
0000100   \n   i   f       [       !       -   d       "   $   w   o   r
0000120    k   d   i   r   "       ]   ;       t   h   e   n  \r  \n    
0000140            m   k   d   i   r       /   u   s   r   /   s   c   r
0000160    i   p   t   /   s   c   r   a   p   e   s  \r  \n   f   i  \r
0000200   \n  \r  \n   c   d       /   u   s   r   /   s   c   r   i   p
0000220    t   /   s   c   r   a   p   e   s  \r  \n  \r  \n   #   d   e
0000240    s   t   =   /   u   s   r   /   s   h   a   r   e   /   e   n
0000260    i   g   m   a   2   /   s   l   y   k   -   1   -   h   d   /
0000300    s   c   r   e   e   n   s  \r  \n   #   i   f       [       !
0000320        -   d       "   $   d   e   s   t   "       ]   ;       t
0000340    h   e   n  \r  \n   #           e   c   h   o       >   &   2
0000360        "   $   d   e   s   t       d   o   e   s       n   o   t
0000400        e   x   i   s   t   "  \r  \n   #               e   x   i
0000420    t       2  \r  \n   #   f   i  \r  \n  \r  \n   #       l   a
0000440    r   g   e       p   i   c   k   1  \r  \n   e   c   h   o    
0000460    s   c   r   a   p   i   n   g       p   i   c   k   1       n
0000500    e   w       p   r   e   m   i   e   r   e   s  \r  \n   w   g
0000520    e   t       -   q       -   O       n   e   w       "   h   t
0000540    t   p   :   /   /   w   w   w   .   s   k   y   .   c   o   m
0000560    /   t   v   /   c   h   a   n   n   e   l   /   s   k   y   c
0000600    i   n   e   m   a   /   g   a   l   l   e   r   y   /   c   o
0000620    m   i   n   g   -   s   o   o   n   -   t   o   -   s   k   y
0000640    -   c   i   n   e   m   a   -   p   r   e   m   i   e   r   e
0000660    "  \r  \n   g   r   e   p       -   E   o       "   h   t   t
0000700    p   :   /   /   w   w   w   .   a   s   s   e   t   1   .   n
0000720    e   t   /   t   v   /   p   i   c   t   u   r   e   s   /   m

thanks for your help on this, i know i keep saying it but it is greatly appreciated

[birdman]

thanks for the reply birdman

ran the command, here's the 1st 30 lines :

root@vuduo2:/usr/script# od -c ./toppicks1.sh
0000000    #   !   /   b   i   n   /   s   h  \r  \n   #  \r  \n  \r  \n

thanks for your help on this, i know i keep saying it but it is greatly appreciated

Well, there's your problem.

The \r\n (i.e. <CR><LF>).

That file is a DOS text file, not a Unix one. You need to get rid of the <CR>s (\r).

[birdman]

However, back to the actual scripts.


toppicks1.sh:

workdir=/usr/script/scrapes
if [ ! -d "$workdir" ]; then
   mkdir /usr/script/scrapes
fi

should really be:

workdir=/usr/script/scrapes
if [ ! -d "$workdir" ]; then
   mkdir "$workdir"
fi

toppicks2.sh:
This uses let, which is a bash-only construct, so line one should be #!/bin/bash (in case that isn't a symlink to bash, which it isn't on Vix by default).

        if [ $pick == 1 ]; then

should be

        if [ $pick -eq 1 ]; then

since you are expecting it to be a number, not text.

        if [ $pick == 1 ]; then
.
        elif [ $pick == 2 ]; then
.
        elif [ $pick == 3 ]; then
.
        else

is better done as:

case $pick in
1)
.;;
2)
.;;
3)
.;;
*)
.;;
esac

both:

cd /usr/script/scrapes

should be:

cd /usr/script/scrapes || exit

or

if ! cd /usr/script/scrapes; then
   echo >&2 "Failed to reach /usr/script/scrapes"
fi

since you shouldn't continue on an error.

[grantdavey91]

However, back to the actual scripts.


toppicks1.sh:

workdir=/usr/script/scrapes
if [ ! -d "$workdir" ]; then
   mkdir /usr/script/scrapes
fi

should really be:

workdir=/usr/script/scrapes
if [ ! -d "$workdir" ]; then
   mkdir "$workdir"
fi

toppicks2.sh:
This uses let, which is a bash-only construct, so line one should be #!/bin/sh (in base that isn't a symlink to bash, which it isn't on Vix by default).

        if [ $pick == 1 ]; then

should be

        if [ $pick -eq 1 ]; then

since you are expecting it to be a number, not text.

        if [ $pick == 1 ]; then
.
        elif [ $pick == 2 ]; then
.
        elif [ $pick == 3 ]; then
.
        else

is better done as:

case $pick in
1)
.;;
2)
.;;
3)
.;;
*)
.;;
esac

both:

cd /usr/script/scrapes

should be:

cd /usr/script/scrapes || exit

or

if ! cd /usr/script/scrapes; then
   echo >&2 "Failed to reach /usr/script/scrapes"
fi

since you shouldn't continue on an error.

thanks birdman; would you mind editing the relevant lines and re-upload the scripts as a zip so i can then put on the box and unzip them to /us/script as i did before; i think the main issue is that i am using a mac but with your help on the last script it seemed to work without me needing to open the files

i think its time for me to consider going back to windows

thanks

[birdman]

thanks birdman; would you mind editing the relevant lines and re-upload the scripts as a zip

I don't currently have time to test them, but here they are.

Unix-Archive.zip

i think its time for me to consider going back to windows

thanks

That wouldn't help. The files in the Archive.zip were Unix text files (even though they were created on a Mac). It was the transfer to the Vix box which somehow changed them into DOS text files.
I suspect you'd have the same issue on a transfer from Windows.
But you haven't yet said how you actually get the files onto the Vix box..

[grantdavey91]

I don't currently have time to test them, but here they are.



i think its time for me to consider going back to windows

thanks

[/QUOTE]

no probs, there's no rush mate; did you upload the files as i can't see anything attached? thanks

[birdman]

no probs, there's no rush mate; did you upload the files as i can't see anything attached? thanks

I pressed the wrong button - and edited it straight afterwards.

[grantdavey91]

I pressed the wrong button - and edited it straight afterwards.

ok no worries, thanks; i'll try it out