Help needed please with cron timer

[birdman]

i am using a mac, and the program i am using is text wrangler ; if that helps

It helps me (to know), but I doubt that it's helping you.
In days gone by Mac systems used <CR> as and end of line marker, whereas all Unix/Linux system use <NL> (and MS Windows/DOS uses <CR><NL>). I'm assuming that this still obtains.
Mind you, the BareBones version of TextWrangler claims that it "Transparently reads and writes DOS, Unix, and Mac files".

i took out the \ but then i got the same error for line 50 :

The "\" was meant to be there - but it is vital that there are no spaces following it. It must be the final character on the line.

You haven't said what happened when you changed it to be all on one line.

[grantdavey91]

It helps me (to know), but I doubt that it's helping you.
In days gone by Mac systems used <CR> as and end of line marker, whereas all Unix/Linux system use <NL> (and MS Windows/DOS uses <CR><NL>). I'm assuming that this still obtains.
Mind you, the BareBones version of TextWrangler claims that it "Transparently reads and writes DOS, Unix, and Mac files".

The "\" was meant to be there - but it is vital that there are no spaces following it. It must be the final character on the line.

You haven't said what happened when you changed it to be all on one line.

Thanks for the reply

Apologies, when you said remove the '\' i assumed i didn't have to paste it back in after moving line 51 to line 50.

I have amended to place the '\' back in the code, i then ran the command again and was presented with the same error for line 62 :

./toppicks2.sh: line 62: syntax error: unexpected word (expecting "do")

so i placed '\' at the end of line 62 which resolved this one

I then ran the command again and I got :

./toppicks2.sh: line 71: syntax error: unexpected word (expecting "done")

line 71 on the script is literally 'done' wothout the quotation marks

I added '\' thinking this would resolve, but i still got:

./toppicks2.sh: line 71: syntax error: unexpected word (expecting "done")

It's so very close now as it's only complaining about the last line

any ideas?

Thanks

[dsayers]

Try and make it in line with the top line so

    wget -q $url1$username$url2$link -O ${dest}/$name
    done

I still haven't gòt round to playing with this but hopefully will tonight

[grantdavey91]

Try and make it in line with the top line so

    wget -q $url1$username$url2$link -O ${dest}/$name
    done

I still haven't gòt round to playing with this but hopefully will tonight

thanks dsayer, just tried that, didn't work unfortunately

[birdman]

Try and make it in line with the top line so

This isn't python. It's a shell script and you can format it how you wish to enhance readability.

[grantdavey91]

This isn't python. It's a shell script and you can format it how you wish to enhance readability.

i'm giving everything i can think of a try but not succeeding at the moment, it is literally the very last line it's not happy with saying 'expecting done' but the last line says 'done' and doesn't have any trailing whitespace

[birdman]

Apologies, when you said remove the '\' i assumed i didn't have to paste it back in after moving line 51 to line 50.

You shouldn't. But you didn't mention that you'd combined the lines into one.

./toppicks2.sh: line 62: syntax error: unexpected word (expecting "do")

so i placed '\' at the end of line 62 which resolved this one

Removing an error message does not necessarily mean that you have resolved what was causing it. You've just combined that line with the next one and moved the reported problem elsewhere.

All I can assume is that the fact that you are editing things on a Mac then transferring them onto the box is causing a text formatting problem in the script.
That script runs fine for me on my box, and on my desktop and laptop, which run Linux Mint. It's just a simple shell script.

If you tell me what workdir setting you wish to use I could post a version with that edited in, so you wouldn't need to edit at all and we could see how that gets on.

[birdman]

i'm giving everything i can think of a try but not succeeding at the moment, it is literally the very last line it's not happy with saying 'expecting done' but the last line says 'done' and doesn't have any trailing whitespace

It should have a trailing newline, though.
I know that some editors think that this isn't needed....

[grantdavey91]

You shouldn't. But you didn't mention that you'd combined the lines into one.

Removing an error message does not necessarily mean that you have resolved what was causing it. You've just combined that line with the next one and moved the reported problem elsewhere.

All I can assume is that the fact that you are editing things on a Mac then transferring them onto the box is causing a text formatting problem in the script.
That script runs fine for me on my box, and on my desktop and laptop, which run Linux Mint. It's just a simple shell script.

If you tell me what workdir setting you wish to use I could post a version with that edited in, so you wouldn't need to edit at all and we could see how that gets on.

sorry, i thought i had mentioned it ; apologies - my brain is just going to mush trying to get this to work

well at first because many others had the same script and it was working for them i assumed it could be something to do with my box, and when i posted up the script i them thought after your reply that the script was wrong even though it was working for some, but i agree and you are more than likely right that its something to do with the editing on mac

by workdir do you mean where the images will be saved? this will bee /usr/share/enigma2/slyk-1-hd/skyicons

or where the script is going to be on the box /usr/script/toppicks2

thanks birdman, really appreciate the help; apologies for my lack of knowledge at this point

[birdman]

by workdir do you mean where the images will be saved? this will bee /usr/share/enigma2/slyk-1-hd/skyicons

or where the script is going to be on the box /usr/script/toppicks2

The latter. i.e. the value for workdir in the script.

This one should be all set up for you.

toppicks2.sh.zip

I suggest you copy the zip file into /usr/script/toppicks2 then run

unzip toppicks2.sh.zip

to ensure that you have an exact copy of what I have...

[ccs]

..... don't forget to cd /usr/script/toppicks2 before unzipping.

[grantdavey91]

The latter. i.e. the value for workdir in the script.

This one should be all set up for you.

toppicks2.sh.zip

I suggest you copy the zip file into /usr/script/toppicks2 then run

unzip toppicks2.sh.zip

to ensure that you have an exact copy of what I have...

LEGEND! IT WORKED!!

Birdman, thank you so much for all your help; really appreciate it; I've asked all over the place and got help but no fix

Now I can set up the cron to run it automatically and i'm not going to touch it

but for future purposes for other scripts i may get involved in for the future, would you happen to know if there are any mac based apps/programs I will be able to edit shell on without having the same problem again? no worries if not

thanks again Birdman, I bet it's a relief for you too, I can now stop pestering you haha!

[birdman]

but for future purposes for other scripts i may get involved in for the future, would you happen to know if there are any mac based apps/programs I will be able to edit shell on without having the same problem again? no worries if not

The editor you are using claims to be able to handle Mac, Unix and DOS text files "automatically". Perhaps there is a "Save" option that lets you force the text format?
But there is also the issue of how you then get the files onto the box - you haven't said how you do that.
If you are using FTP then you could either write the file in Unix format then transfer it as a binary file, or write it in Mac format then transfer it as an ASCII/text one.

[grantdavey91]

The editor you are using claims to be able to handle Mac, Unix and DOS text files "automatically". Perhaps there is a "Save" option that lets you force the text format?
But there is also the issue of how you then get the files onto the box - you haven't said how you do that.
If you are using FTP then you could either write the file in Unix format then transfer it as a binary file, or write it in Mac format then transfer it as an ASCII/text one.

I'll have a look to see if it has that possibility - that's a very good point - I only ever save as ASCII/text unless it's already binary ; i'll have a look at the settings/preferences on text wrangler (i'm told it's the best editor for mac and the equivalent of notepad++)

[grantdavey91]

I'll have a look to see if it has that possibility - that's a very good point - I only ever save as ASCII/text unless it's already binary ; i'll have a look at the settings/preferences on text wrangler (i'm told it's the best editor for mac and the equivalent of notepad++)

Hi, birdman

I looked at the text wrangler preferences; I can change to different editors and download additional formats if needed ; the application itself is apparently already saving as unix ; but one thing on this i never noticed before; it has it's own built in script editor which i wasn't using for the shell; just the default text wrangler ; and it also has the function to check syntax before running commands

Screen Shot 2016-09-19 at 17.54.39.pngScreen Shot 2016-09-19 at 17.54.03.jpgScreen Shot 2016-09-19 at 17.53.25.jpg