GB Quad Plus, Mut@nt HD51, AX HD61, 80cm dish and Supreme Dark motor. Sony STR-DN 1060, Sony UHP-H1 Bluray, Odroid N2+ (CoreElec), Monitor Audio Bronze 5.1 speakers
ccs (19-02-21)
Help asked via PM will be ignored.
The forum is there for help and all will benefit from your questions.
NO CARD SHARING TALK WILL BE TOLERATED, LAN OR WAN, IN OPEN FORUM OR PM !
English is not my native tongue.
I apologise for all my grammar, spelling and idiom errors.
I've just added the patch again, and now epg/green shows the Enable VPS option=No, whether Enable VPS in the plugin is set to yes or no.
Rob - as ccs says, you may want to switch off the VPS setting in the timer. In an AutoTimer, the option to use VPS is controllable.
GB Quad Plus, Mut@nt HD51, AX HD61, 80cm dish and Supreme Dark motor. Sony STR-DN 1060, Sony UHP-H1 Bluray, Odroid N2+ (CoreElec), Monitor Audio Bronze 5.1 speakers
I know, which was why I was telling you all not to mention it.
ALL I'm trying to confirm at the moment is that the fix I have made works - which is ONLY to get the VPS entry to show up on manual timer (and instant records) which it was not doing previously (at 5.4. Please do NOT mention 5.3).
Of course now it is there is will exhibit the other problems.
I'm trying to solve the issues in small steps, so that I can commit individual PRs. (Even God apparently took 6 days to piece the universe together, not do it all in one go....)
Last edited by birdman; 19-02-21 at 20:34.
MiracleBox Prem Twin HD - 2@DVB-T2 + Xtrend et8000 - 5(incl. 2 different USBs)@DVB-T2[terrestrial - UK Freeview HD, Sandy Heath] - LAN/USB-stick/HDD
I don't know, because it's not there. At least not that I can see.
But I'm proceeding through the known problems one at a time.
The next one I'm going to look at is why the VPS option doesn't show up when you have "Default On" set. My suspicion is that this is an incorrect use of the word Default. I reckon it makes more sense to always put the option in the menu and have the Default determine the starting value.
And whilst looking into this I may find out what the code is trying to do as, so far, I haven't had time to figure that out.
MiracleBox Prem Twin HD - 2@DVB-T2 + Xtrend et8000 - 5(incl. 2 different USBs)@DVB-T2[terrestrial - UK Freeview HD, Sandy Heath] - LAN/USB-stick/HDD
There are quite a number of issues with English translation from German(I presume) in the note for the plugin which makes the program description difficult to understand. It's possible the "Default On" setting in the VPS config menu means that the entry in the timer menu should read "VPS yes". It's difficult to ascertain or there is ambiguity in working out what the author actually meant. As regards the instant records, that has always offered the VPS option in 5.4 prior to any of your changes.
GB Quad Plus, Mut@nt HD51, AX HD61, 80cm dish and Supreme Dark motor. Sony STR-DN 1060, Sony UHP-H1 Bluray, Odroid N2+ (CoreElec), Monitor Audio Bronze 5.1 speakers
I've submitted a PR (well, two - one for master and another for dev) for this.
Now I can sit down with a listing and pen to sort out what this thinks it is doing.Code:https://github.com/oe-alliance/enigma2-plugins/pull/412 https://github.com/oe-alliance/enigma2-plugins/pull/413
MiracleBox Prem Twin HD - 2@DVB-T2 + Xtrend et8000 - 5(incl. 2 different USBs)@DVB-T2[terrestrial - UK Freeview HD, Sandy Heath] - LAN/USB-stick/HDD
Joe_90 (20-02-21)
I downloaded VPS from my ATV image and ran some tests. Manual timer entry has VPS option available and it saves it properly (Yes/No/Yes safe-mode). Actual recordings are as expected - start and stop on EIT programme boundaries in strict mode and obey user padding in safe-mode.
GB Quad Plus, Mut@nt HD51, AX HD61, 80cm dish and Supreme Dark motor. Sony STR-DN 1060, Sony UHP-H1 Bluray, Odroid N2+ (CoreElec), Monitor Audio Bronze 5.1 speakers
Andy_Hazza (20-02-21)
Yes.
I can believe that, given what I read ~2mins ago....
The VPS plugin traps a keyGo() function, which it expects to be called when a timer is saved, and this causes it to set things up to be put into the timer_xps.xml file.
However, the Timer refactoring code deprecated keyGo() in favour of keySave(). And whereas TimerEntryBase does re-route keyGo() calls to keySave(), the key-press in the menu is bound to keySave().
So currently the VPS menu entry code is skipped in Vix on saving the entry, which explains why it is ignored.
Should be(?) a trivial fix - keyGo() and keySave() have identical calling sequences - it's just a name change.
EDIT: Yes, it was trivial. And would have been even quicker had I not left in a failing debug line I added yesterday. My timers_vps.xml file is now being updated.
EDIT2: PR submitted:<?xml version="1.0" ?>
<vps_timers>
<timer begin="1613840400" end="1613841900" serviceref="1:0:19:A010:A000:233A:EEEE0000:0:0:0:" vps_enabled="1" vps_overwrite="1" vps_time="0">
</timer>
<timer begin="1613840401" end="1613841900" serviceref="1:0:1:1C00:104D:233A:EEEE0000:0:0:0:" vps_enabled="1" vps_overwrite="0" vps_time="0">
</timer>
</vps_timers>
Code:https://github.com/oe-alliance/enigma2-plugins/pull/414
Last edited by birdman; 20-02-21 at 17:55.
MiracleBox Prem Twin HD - 2@DVB-T2 + Xtrend et8000 - 5(incl. 2 different USBs)@DVB-T2[terrestrial - UK Freeview HD, Sandy Heath] - LAN/USB-stick/HDD
For anyone interested, this is the updated file:
Modifications.py
MiracleBox Prem Twin HD - 2@DVB-T2 + Xtrend et8000 - 5(incl. 2 different USBs)@DVB-T2[terrestrial - UK Freeview HD, Sandy Heath] - LAN/USB-stick/HDD