GB Quad+ Timeshift crash

[twol]

Ask Birdman for comments

[birdman]

Ask Birdman for comments

Well, the change you made prevents a directory pathname, rather than a file pathname, being set for the timeshift buffer.
This situation also occurs at line 253 and 1197 in the same file.
So it might be better to fix all of them....

They are all associated with setting self.pts_switchtolive to True, so I reckon changing the ptsSetNextPlaybackFile() code to be:

        def ptsSetNextPlaybackFile(self, nexttsfile):
                # print '!!!!! ptsSetNextPlaybackFile'
                ts = self.getTimeshift()
                if ts is None:
                        return
# Prepend timeshift dir, unless we are setting nothing ("")
                if nexttsfile != "":
                        nexttsfile = "%s%s" % (config.usage.timeshift_path.value, nexttsfile)
                # print ("!!! SET NextPlaybackFile nexttsfile)
                ts.setNextPlaybackFile(nexttsfile)

will be better, as this will handle all of them by not prepending the timeshift directory name when it is actually trying to not set any file. This code ends up setting m_timeshift_file_next in lib/service/service/dvb.cpp and there are various checks for this being an empty string, all associated with it switching to live TV.

Here's a version of Timeshift.py with this fix applied.

Timeshift.zip

[birdman]

Here's a version of Timeshift.py with this fix applied.

Note that this is different to what you did, but I suspect it fits in with what is intended elsewhere in the code.