Recording indicator on EPG

[Orlandox]

I guess maybe we could add a margin to workaround this, e.g. here: https://github.com/OpenViX/enigma2/b...stGrid.py#L533

Change to:

timer, matchType = RecordTimer.isInTimerOnService(serviceTimers, stime + (20 if config.recording.margin_before.value == 0 else 0), duration)

I can confirm that change did the trick (Margin before recording (minutes) is set 0), thank you Huevos.

EPG_rec2.jpg

EPG_timers2.jpg

[Huevos]

BTW, why would anyone want to set their default start margin for every recording to 120 minutes before the program begins?

[birdman]

BTW, why would anyone want to set their default start margin for every recording to 120 minutes before the program begins?

Why would you wish to stop them if that is their desire?

[littlejim]

I think the idea is that in some cases (Unicable) asking two tuners to retune at exactly the same moment doesn't work.
So a workaround was made so that there never are two timers starting at exactly the same time: a timer starting at the same time as another will be changed to start 1 second later instead.

Later:
How about changing it to 1 second earlier instead?

[Huevos]

I think the idea is that in some cases (Unicable) asking two tuners to retune at exactly the same moment doesn't work.
So a workaround was made so that there never are two timers starting at exactly the same time: a timer starting at the same time as another will be changed to start 1 second later instead.

Isn't that what I already explained?

How about changing it to 1 second earlier instead?

Because the whole idea of zero is to reduce timer conflicts. Adding -1 would create start times before the program boundary, adding conflict when resources are limited.

[littlejim]

Or why not do it properly and implement a critical region using semaphores in the code that sends Unicable commands?

[Huevos]

Or why not do it properly and implement a critical region using semaphores in the code that sends Unicable commands?

I look forward to receiving your pull request.

[Orlandox]

timer, matchType = RecordTimer.isInTimerOnService(serviceTimers, stime + (20 if config.recording.margin_before.value == 0 else 0), duration)[/CODE]

@Huevos, are you going to commit this ?

[Huevos]

@Huevos, are you going to commit this ?

I was but Littlejim says I'm doing it all wrong and c++ needs a rewrite.

[birdman]

I was but Littlejim says I'm doing it all wrong and c++ needs a rewrite.

You can do mutex locking in Python.

[Huevos]

You can do mutex locking in Python.

Nothing to do with Python.

This issue was unsolved for months before the workaround was introduced. Now someone knows exactly the correct way to fix it. Well if he is so clever let him send a pull request.

[Orlandox]

I was but Littlejim says I'm doing it all wrong and c++ needs a rewrite.

But commit this version, please. Rewriting is maybe coming later ?