missing epg data - opentv

[urie]

@abu baniaz, with reguards to OpenTV zapper do you think it could be ported to openatv, I use epg refresh I select a few channels only for freeview bbc one and E4 but with reguards to IEPG data 1 when I select that in epgrefresh obviously no signal as to speak in autobouqets maker I don't want to have bouquet sky info shown and in epg main setting i have nothing enabled
I know I can just select a channel on freeview and epg will be pulled in but would be good to have epg there without having to zap to a channel if possible
1.jpg

[abu baniaz]

You will have to ask ATV, but it is just a zapper. You can select iepg from service list instead of bouquet.

[Joe_90]

Do no other people find that flicking from channel to channel (satellite channels) while OpenTV EPG download starts doesn't cause a problem?

I'm wondering if it's some weird bug that's specific to Zgemma or to the Zgemma H7.

Definitely causes an issue (sometimes!). I can't pin it down. I know if I don't disturb the download, then I have no issues with the EPG.

[LraiZer]

So this huffman issue only happens when a user zapperdy zap zap zaps on multi-tuner box... eg. zapping tuner 1 while opentv zapper has also initiated an epg download on tuner 2?

Many..

< 438.7103> 17:45:54.2754 [huffman] Error. Cannot decode Huffman data

huffman_root is being reset to NULL each zap prior to the check for valid epg transpoder in the call to the huffman_read_dictionary() function.

I think moving the code in huffman.cpp for the epg transponder validation check so that it is above the huffman_root NULL should stop those huffman decode errors.

diff --git a/lib/base/huffman.cpp b/lib/base/huffman.cpp
index 70ef87c8a8..a8e6be661c 100644
--- a/lib/base/huffman.cpp
+++ b/lib/base/huffman.cpp
@@ -12,6 +12,13 @@ type_huffman_node huffman_root;
 bool huffman_read_dictionary (char *file)
 {
 	FILE *fd;
+	fd = fopen (file, "r");
+
+	if (!fd)
+		return false;
+	else
+		eDebug("[huffman] read.. '%s'", file);
+
 	char line[512];
 	char value[256];
 	char code[256];
@@ -24,15 +31,6 @@ bool huffman_read_dictionary (char *file)
 	huffman_root.p0 = NULL;
 	huffman_root.p1 = NULL;
 
-	eDebug("[huffman] read.. '%s'", file);
-
-	fd = fopen (file, "r");
-	if (!fd)
-	{
-		//eDebug("[huffman] Cannot open dictionary file");
-		return false;
-	}
-
 	while (fgets (line, sizeof(line), fd))
 	{
 		memset (value, 0, sizeof (value));

[Joe_90]

So this huffman issue only happens when a user zapperdy zap zap zaps on multi-tuner box... eg. zapping tuner 1 while opentv zapper has also initiated an epg download on tuner 2?

Many..


huffman_root is being reset to NULL each zap prior to the check for valid epg transpoder in the call to the huffman_read_dictionary() function.

I think moving the code in huffman.cpp for the epg transponder validation check so that it is above the huffman_root NULL should stop those huffman decode errors.

...

Yep - I think that about describes the error situation - zapping while the OpenTVzapper is running seems to trigger the runaway error messages. It would be great if a code change could be made. Happy to test.

[abu baniaz]

I have submitted a pull request here: https://github.com/OpenViX/enigma2/pull/849
A build will need to be run for it to be tested

[LraiZer]

patch missing this line from above...

-	eDebug("[huffman] read.. '%s'", file);

[abu baniaz]

@joe_90
Any update on the change. If OK, we can submit pull request to other images.

[Joe_90]

Waiting on dev build 6.3.004.013 - the 011 and 012 builds did not work for me as there was a bug in menu.py which surfaced in my sorted menu. I did run the 012 build for a couple of days unattended on my single tuner HD61and the scheduled run of OpenTVzapper worked fine, but I didn't try to provoke the huffman error. Once 013 is available I will download later tonight on my Quad Plus and test.

[Joe_90]

Dev build 013 does not seem to have completed for ax61HD. I did flash the 013 build for the QuadPlus early this morning and will test it.

[Joe_90]

Dev build 014 has completed for the AX61HD. Have downloaded and flashed ok. Looks good so far. My AX61HD has only a single DVB-S tuner, so can't verify huffman issue on it. I am testing that on the Quad Plus.

[Joe_90]

Dev build 014 for Quad Plus tested for the "huffman error" bug. I can't provoke the runaway log error, despite switching DVB-S and DVB-T channels and starting recordings etc. while the OpenTVZapper is running. Problem seems fixed on the development/test image. Should be good for Release. Thanks @LraiZer and @abu baniaz!

[BrianG61UK]

I just built myself a 6.3.004.015 developer image for my Zgemma H7S and I too am unable to provoke it into showing blank EPG entries by doing things like channel zapping while OpenTV EPG download is occurring.

This is most excellent news.

Thank you @LraiZer.