Hello Guest, if you are reading this it means you have not registered yet. Please take a second, Click here to register, and in a few simple steps you will be able to enjoy our community and use our OpenViX support section.
Page 2 of 2 FirstFirst 12
Results 16 to 28 of 28

Thread: My YouViX Blue modification

  1. #16
    Huevos's Avatar
    Title
    Administrator
    Join Date
    Jun 2010
    Location
    38.5N, 0.5W
    Posts
    12,898
    Thanks
    1,957
    Thanked 4,572 Times in 3,025 Posts
    So this no longer depends on the common skin? That would make things simpler... but... can't commit like that. All the makefiles are missing.

  2. #17

    Title
    ViX Beta Tester
    Join Date
    Nov 2020
    Posts
    373
    Thanks
    119
    Thanked 34 Times in 27 Posts
    Quote Originally Posted by Huevos View Post
    So this no longer depends on the common skin? That would make things simpler... but... can't commit like that. All the makefiles are missing.
    Yes, only 1 folder 'YouViX-Blue-Mod'. What are 'makefiles' ?

    Is it Makefile.am ?

    Looks like this ?

    installdir = $(datadir)/enigma2/YouViX-Blue-Mod

    SUBDIRS = buttons countries crossepg epg extensions fonts icons imdb infobar logos menuicons networkbrowser ondemand pvr screens selectionbars spinner vixcore

    dist_install_DATA = *.png *.xml


    Does it also need 'meta' folder ?

  3. #18
    Huevos's Avatar
    Title
    Administrator
    Join Date
    Jun 2010
    Location
    38.5N, 0.5W
    Posts
    12,898
    Thanks
    1,957
    Thanked 4,572 Times in 3,025 Posts
    Yes, there needs to be a makefile in every folder and then they all need listing in configure.ac.
    https://github.com/OpenViX/skins/blo...e.ac#L286-L299

    So have a look at the ones in the current folders for the basics.

  4. The Following User Says Thank You to Huevos For This Useful Post:

    Orlandox (05-03-23)

  5. #19

    Title
    ViX Beta Tester
    Join Date
    Nov 2020
    Posts
    373
    Thanks
    119
    Thanked 34 Times in 27 Posts
    Hello Huevos,

    here is the YouViX-Blue-Mod zip file with Makefile.am added to each folder + meta folder added with files Makefile.am and skin_YouViX-Blue-Mod.xml.
    So, I modified configure.ac. Do I need to make a PR for both ?

    YouViX-Blue-Mod_05032023.zip

    configure.zip
    Last edited by Orlandox; 05-03-23 at 09:58.

  6. #20

    Title
    ViX Beta Tester
    Join Date
    Nov 2020
    Posts
    373
    Thanks
    119
    Thanked 34 Times in 27 Posts
    Thank you @Huevos for adding my skin !

    If changes are needed in the future, how do I commit them ? By creating PR ?
    Last edited by Orlandox; 05-03-23 at 18:01.

  7. #21
    Huevos's Avatar
    Title
    Administrator
    Join Date
    Jun 2010
    Location
    38.5N, 0.5W
    Posts
    12,898
    Thanks
    1,957
    Thanked 4,572 Times in 3,025 Posts
    You can check if that worked ok by reflashing with the latest Dev build.

    Yes, just create PRs.

  8. #22

    Title
    ViX Beta Tester
    Join Date
    Nov 2020
    Posts
    373
    Thanks
    119
    Thanked 34 Times in 27 Posts
    Hello @Huevos,

    I made https://github.com/OpenViX/skins/pull/74 couple of days ago, is it okay ? When you have time, can you please check it ?

  9. #23
    abu baniaz's Avatar
    Title
    Moderator
    Join Date
    Sep 2010
    Location
    East London
    Posts
    22,957
    Thanks
    6,234
    Thanked 8,980 Times in 6,091 Posts
    I don't see why changes to fix a skin have to be a new skin.

  10. The Following User Says Thank You to abu baniaz For This Useful Post:

    Orlandox (10-03-23)

  11. #24
    Huevos's Avatar
    Title
    Administrator
    Join Date
    Jun 2010
    Location
    38.5N, 0.5W
    Posts
    12,898
    Thanks
    1,957
    Thanked 4,572 Times in 3,025 Posts
    Quote Originally Posted by abu baniaz View Post
    I don't see why changes to fix a skin have to be a new skin.
    Because they are not changes to fix a skin. They are modifying the skin. And from the start point there was no proper commit record of the skin mods. So now Orlandox has his own play area.

    By the way I had to fix the build because of this skin: https://github.com/OpenViX/skins/com...9360ea49186605

  12. The Following User Says Thank You to Huevos For This Useful Post:

    abu baniaz (10-03-23)

  13. #25

    Title
    ViX Beta Tester
    Join Date
    Nov 2020
    Posts
    373
    Thanks
    119
    Thanked 34 Times in 27 Posts
    Okay, and thank you Huevos ! Just made a PR about those dot.png and fulldot.png (copied from your skin ).

  14. #26
    Huevos's Avatar
    Title
    Administrator
    Join Date
    Jun 2010
    Location
    38.5N, 0.5W
    Posts
    12,898
    Thanks
    1,957
    Thanked 4,572 Times in 3,025 Posts
    Quote Originally Posted by Orlandox View Post
    Just made a PR about those dot.png and fulldot.png. Where they are used? How to test?
    So this is experimental code. In Setup lists and other lists that use your MenuConfigWidget in templates.xml, (you can experiment with other lists and widgets too), you can lose the scrollbar and add the pagination icons instead.

    Something like this in templates:
    Code:
    	<!-- ## MENU WIDGETS ## -->
    	<screen name="MenuConfigWidget">
    		<widget name="config" objectTypesInverted="config,ConfigList" position="680,157" size="1160,765" font="youvix-r;27" itemHeight="45" foregroundColor="white" backgroundColor="menubackground" transparent="1" enableWrapAround="1" scrollbarMode="showOnDemand" zPosition="1" />
    		<widget name="config" objectTypes="config,ConfigList" position="680,157" size="1160,720" font="youvix-r;27" itemHeight="45" foregroundColor="white" backgroundColor="menubackground" transparent="1" enableWrapAround="1" scrollbarMode="never" zPosition="1" />
    		<widget addon="Pager" connection="config" objectTypes="config,ConfigList" position="680,890" size="1160,25" spacing="30" transparent="1" backgroundColor="background" />
    	</screen>
    Attached Images Attached Images
    • File Type: jpg 1.jpg (37.6 KB, 17 views)
    • File Type: jpg 2.jpg (39.5 KB, 16 views)
    • File Type: jpg 3.jpg (36.6 KB, 15 views)

  15. The Following User Says Thank You to Huevos For This Useful Post:

    Orlandox (11-03-23)

  16. #27

    Title
    ViX Beta Tester
    Join Date
    Nov 2020
    Posts
    373
    Thanks
    119
    Thanked 34 Times in 27 Posts
    Tested and okay, except this must be scrollbarMode="showNever", just for an info, if someone want to use that.

  17. #28
    Huevos's Avatar
    Title
    Administrator
    Join Date
    Jun 2010
    Location
    38.5N, 0.5W
    Posts
    12,898
    Thanks
    1,957
    Thanked 4,572 Times in 3,025 Posts
    Quote Originally Posted by Orlandox View Post
    Tested and okay, except this must be scrollbarMode="showNever", just for an info, if someone want to use that.
    Nobody's perfect! I'm glad I've got you to keep an eye on me.

Page 2 of 2 FirstFirst 12

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
This website uses cookies
We use cookies to store session information to facilitate remembering your login information, to allow you to save website preferences, to personalise content and ads, to provide social media features and to analyse our traffic. We also share information about your use of our site with our social media, advertising and analytics partners.