Cannot move up and down in a Setup screen

[Huevos]

So if they work they can be added here... and here:
https://github.com/OpenViX/enigma2/b...ordings.py#L88
https://github.com/OpenViX/enigma2/b...meshift.py#L72

[Huevos]

Are hardlinks used for recordings, just timeshift or both? If just for timeshift, is it possible to apply the newly added prohibition just for timeshift?

Hardlinks are used for Timeshift, which is why the test is done in that module, but it makes sense we use identical file systems in both modules.

[birdman]

So if they work they can be added here... and here:
https://github.com/OpenViX/enigma2/b...ordings.py#L88
https://github.com/OpenViX/enigma2/b...meshift.py#L72

That won't work.
That code picks up the file system type from /proc/mounts, which for ntfs will list it as fuseblk, as it's run by a user-space daemon. Other file-systems could also show up as fuseblk there and not work (such as exfat).
The only real test for a file-system is to try hard-linking and check the result.

[Huevos]

vfat shows as vfat. The tests for writeablility and hardlinks happen additionally.

[birdman]

vfat shows as vfat.

Which has no relevance at all to ntfs, which doesn't show as ntfs.

The tests for writeablility and hardlinks happen additionally.

So why bother checking the file-system type at all? Although I can see why you might want a blacklist (e.g. to rule out tmpfs, which would pass the tests while not being useful for recordings).

[Huevos]

You said:

Other file-systems could also show up as fuseblk there and not work (such as exfat).
The only real test for a file-system is to try hard-linking and check the result.

Which is why I mentioned vfat (fat32).

Anyway if it works add it to the list.

[birdman]

Anyway if it works add it to the list.

>>Sigh<<.. There is no point, as it won't show up as ntfs but as fuseblk! And exfat would also show up as fuseblk, but that won't work.

(Let's hope this doesn't go round the loop again.)

So, why not make that list a blacklist rather then a whitelist, which makes much more sense if the writeable and hard-linkable tests also have to pass anyway.

[Huevos]

Add fuseblk. And anything that fails the hard link test won't be allowed.

[Huevos]

Also, if you want a black list can you compile one?

[abu baniaz]

I don't see any reason why we should prevent users from using devices with working file systems for recording. As in the OP's case, even though he has been locked out of the menu, he can record/playback fine. For arguments sake, somebody's internal HDD on receiver fails, he can use an external ntfs one until replacement arrives.

The hardlinks issue is specific to timeshift only, so any prohibitions should apply to that functionality only.

[birdman]

Also, if you want a black list can you compile one?

I expect so. I'll track them down (whether a Vix system might have them or not).

[birdman]

OK. Based on my laptop, plus a few more obvious ones (such as assuming you wouldn't want to use the UBI storage for recordings?) I've got a blacklist of:

autofs      binfmt_misc bpf     cgroup2 configfs    debugfs devpts 
devtmpfs    efivarfs    exfat   fuse.portal     fuseblk     fusectl  
hugetlbfs   isofs   jffs2   mqueue  proc    pstore  securityfs  sysfs    
tmpfs       tracefs ubi     ubifs   udf     vfat

There are others, but I can't see that they'd ever end up on a Vix box.

[birdman]

Still leaves an issue for picons, which are only allowed on

 frozenset(('ext4', 'ext3', 'ext2', 'reiser', 'reiser4', 'jffs2', 'ubifs', 'rootfs'))

There's no hard-link test, so adding ntfs would be an issue. (And I have my picons on a vfat file-system, as I put them there "by-hand" rather than using the Plugin Browser, so have no hard links)

[Huevos]

I don't see any reason why we should prevent users from using devices with working file systems for recording. As in the OP's case, even though he has been locked out of the menu, he can record/playback fine. For arguments sake, somebody's internal HDD on receiver fails, he can use an external ntfs one until replacement arrives.

The hardlinks issue is specific to timeshift only, so any prohibitions should apply to that functionality only.

We are not stopping anyone from anything. Birdman and I are just discussing a formula we can all agree on. And anyway the project is open source so users can do what they like on there own box.

[Huevos]

Still leaves an issue for picons, which are only allowed on

 frozenset(('ext4', 'ext3', 'ext2', 'reiser', 'reiser4', 'jffs2', 'ubifs', 'rootfs'))

There's no hard-link test, so adding ntfs would be an issue. (And I have my picons on a vfat file-system, as I put them there "by-hand" rather than using the Plugin Browser, so have no hard links)

Anyway picons use softlinks not hardlinks.