Renaming saved recording needs exit from that directory to get title changed (MovieSelection.py)

**Willo3092** · 04-10-21, 13:05

Originally Posted by ccs

Something very similar (same crash) was fixed 4 days ago by this commit, (Setting yellow button to "toggle mark" in movielist) ....

Yes 5.4.015 - That commit works for me now thanks

**ccs** · 24-11-21, 15:30

Originally Posted by ccs

Aren't movielist collections an option?

For example, I have recordings of "Lewis" and "New: Lewis", so there are 2 collections.

I'm looking for 1 collection (probably called "New: Lewis"), with both "Lewis" and "New: Lewis" showing in that one collection.

"New:" could be a configurable option.

I've found an easy way of doing this.

Go into a collection and mark every entry using the zero key.

Then menu gives you the option to rename the programme, allowing you to add or remove New: for the whole collection in one go.

**LbCwby** · 01-12-21, 22:32

@CCS: I'm glad that works for batch renaming.

The original question though:to see a renamed recording with that changed name, you have to go out of the movie-list and back in, or to a different directory and back, I have not seen tackled/adressed.
I'm now at OpenVIX 6.0.003 and using the Magic-FHD skin, but this not-refreshing of the list has been "off" since somewhere 5.4.008 or so.
The, for me, strange thing is that it does refresh and show the changed name when renaming a directory.
Maybe that last part can help determine if and where some code is missing.

**birdman** · 01-12-21, 23:26

Originally Posted by LbCwby

The, for me, strange thing is that it does refresh and show the changed name when renaming a directory.
Maybe that last part can help determine if and where some code is missing.

I'll have a look. Easy to reproduce this.

**birdman** · 01-12-21, 23:35

My first suspicion is that renaming a directory actually renames the directory. So it gets visibly changed.

Renaming a recording just involves changing the title in the *.meta file. Somehow need to invalidate the whole current list.

**birdman** · 02-12-21, 02:15

I appear to have have a solution.

Basically the renameCallback() has to assume it has renamed things and hence they may need to be resorted (not just redisplayed). Hence it needs to reload() the data after the renames (which might be a list of them).

Try this version of Screens/MovieSelection.py and see whether it works for you.

MovieSelection.zip

It does leave you on the same index in the list, rather than move with a renamed item, but since you might be renaming multiple items at once this will need to do.

**ccs** · 02-12-21, 16:06

If I rename a recording in the top level of movielist, it leaves me with that renamed recording highlighted.

If I rename a recording stored in a "real" folder, it leaves me with that renamed recording highlighted in the "real" folder.

If I rename a recording inside a "collection", it returns to movielist, highlighting the first entry after deleted items (based on "sort by date").

If I rename that recording back to the "collection" name, the "collection" in movielist is then left highlighted.

**birdman** · 02-12-21, 18:29

Originally Posted by ccs

If I rename a recording ....

But did it fix the issue of immediately displaying the changed name?

f I rename a recording inside a "collection", it returns to movielist, highlighting the first entry after deleted items (based on "sort by date").

What is a "collection"?
Why/how do you have deleted items in a a movielist (that isn't .Trash)?
Is "sort by date" your normal sort method?

**ccs** · 02-12-21, 18:30