Virtual keyboard bugs

[abu baniaz]

Didn't realize making the keyboard look like a keyboard is a mess.

[Sicilian]

Didn't realize making the keyboard look like a keyboard is a mess.

Rowland said the 'code', not the 'look',

[abu baniaz]

Looks are made by code.



Taapat had suggested to make the keyboard look like a real keyboard on PLI, I'm pretty it got rejected by someone. Taapat then added it.

I'm not discussing other colour changes. Just the look.

[abu baniaz]

Correction, it was Pr2

The claim that some languages would lose buttons is contradicted by the fact that not all languages have the wide keyboard.

Is it possible to have the space bar bigger on VK like on real keyboard?

This is not easy to do. The simplicity of the code lies in the easy calculations required to calculate the cursor position. Making any keys an irregular size would complicate the code for little return. This is not a change I would like to tackle at this late stage.



The other issue is that some of the keyboard designs take advantage of every grid location available per screen. Removing available cells would require a rework of all the keyboards.

[IanSav]

Hi,

This is how the PLi keyboard looks like. A keyboard that looks like a real keyboard.

Apparently, this is Eye Candy. So the claim that the changes were to make the keyboard like a real keyboard will not be honoured.

This post does not reflect what I have actually posted. I did call the keyboard "eye candy" because it is visually pleasing. Unfortunately the many bugs and issues with the OpenPLi code have not been reported here. I have not dismissed coming up with a visual update but that won't happen until I can find an acceptable way to code the changes such that the code is not messy, bloated or more complicated than is warranted.

It should also be noted that this visual change will require lots of complex skin changes for OpenViX and all images based on OpenViX.

I stand by my original proposal that the newer VirtualKeyBoard is closer to physical keyboards because the layout / location of the buttons is much closer than the previous version. Having the different sized buttons is nice to look at but has little appreciable benefit when actually using the VirtualKeyBoard.

Regards,
Ian.

[IanSav]

Hi,

The claim that some languages would lose buttons is contradicted by the fact that not all languages have the wide keyboard.

I believe that all the keyboards I edited or created are in the wider form factor. If I have missed any locales please report them to me so I can correct them.

Regards,
Ian.

[Matrix10]

@IanSav

We have this error in Open Black Hole
Space

1165.726> [ActionMap] Keymap 'VirtualKeyBoardActions' -> Action = 'select'
< 1165.726> Traceback (most recent call last):
< 1165.726> File "/usr/lib/enigma2/python/Components/ActionMap.py", line 71, in action
< 1165.726> File "/usr/lib/enigma2/python/Components/ActionMap.py", line 51, in action
< 1165.726> File "/usr/lib/enigma2/python/Screens/VirtualKeyBoard.py", line 992, in processSelect
< 1165.726> File "<string>", line 1
< 1165.726> self['text'].char(.encode('UTF-8'))
< 1165.726> ^
< 1165.726> SyntaxError: invalid syntax

[IanSav]

Hi Matrix10,

@IanSav

We have this error in Open Black Hole
Space

1165.726> [ActionMap] Keymap 'VirtualKeyBoardActions' -> Action = 'select'
< 1165.726> Traceback (most recent call last):
< 1165.726> File "/usr/lib/enigma2/python/Components/ActionMap.py", line 71, in action
< 1165.726> File "/usr/lib/enigma2/python/Components/ActionMap.py", line 51, in action
< 1165.726> File "/usr/lib/enigma2/python/Screens/VirtualKeyBoard.py", line 992, in processSelect
< 1165.726> File "<string>", line 1
< 1165.726> self['text'].char(.encode('UTF-8'))
< 1165.726> ^
< 1165.726> SyntaxError: invalid syntax

From where did the source code come?

Can you please post a copy of VirtualKeyBoard.py that generates this error. May I also have the complete log to follow what happened.

Regards,
Ian.

[birdman]

From where did the source code come?

Looks like:

 https://github.com/OpenPLi/enigma2/blob/develop/lib/python/Screens/VirtualKeyBoard.py

[Matrix10]

https://github.com/OpenPLi/enigma2/b...ualKeyBoard.py

Same with this file.
At the moment of selecting Space with the OK button.

error/ E2 crash


shot1.jpg

[abu baniaz]

This is crashing on openvix too. Thanks for reporting.

Crashlog on other side of forum

[birdman]

Looks like:

 https://github.com/OpenPLi/enigma2/blob/develop/lib/python/Screens/VirtualKeyBoard.py

The problem is the exec(cmd) is evaling this statement (well, there are two...).

u"SPACEICONALT": "self['text'].char(" ".encode('UTF-8'))"
u"SPACEICON": "self['text'].char(" ".encode('UTF-8'))",

which isn't going to work (as those are just two strings concatenated, no space in the middle).
Perhaps:

u"SPACEICONALT": "self['text'].char(' '.encode('UTF-8'))"
u"SPACEICON": "self['text'].char(' '.encode('UTF-8'))",

would work?

[IanSav]

Hi,

Birdman is correct. The issue was caused by nested quotation marks.

Pull requests have been made to the OpenViX and OpenPLi repositories. The OpenPLi request has already been merged.

Regards,
Ian.

[Matrix10]

Perfect now

Thanks to all

shot1.jpg

[Mickkie]

Not sure which recent update caused this, but I don't seem to have a virtual keyboard showing up anymore on OpenVix-5.2.037 when I press the yellow button to perform a new EPG search. I can still press the buttons on my Mut@nt HD51 remote keypad, but I can't delete any characters and therefore cannot edit the string to search with. I assume this is a bug?