Hello Guest, if you are reading this it means you have not registered yet. Please take a second, Click here to register, and in a few simple steps you will be able to enjoy our community and use our OpenViX support section.
Results 1 to 3 of 3

Thread: Making pull requests of translation files. Advice needed!!

  1. #1

    Title
    Member
    Join Date
    Jun 2015
    Posts
    50
    Thanks
    4
    Thanked 13 Times in 9 Posts

    Making pull requests of translation files. Advice needed!!

    Just managed to create my first PR with @Abu“s help to the correct branch. After figuring out how to do that, I would like to ask someone who is familiar with using GITHUB to give us guidelines how to do this properly. Instructions would be nice.

    What I did was:
    - Created an account to Github
    - Searched Enigma2 and Vix repo“s (https://github.com/OpenViX/)
    - Clicked "Fork" to be able to upload file to DEV -branch with browser
    - After upload, clicked "Create a pull request"

    But what about translations for plugins, for example AutoTimer. Where can we find locations for them? Tried searching but didn“t find it.

    In the sticky post there is still mentioned that translated files shoud be sent to site admins.

  2. #2
    abu baniaz's Avatar
    Title
    Moderator
    Join Date
    Sep 2010
    Location
    East London
    Posts
    23,317
    Thanks
    6,410
    Thanked 9,142 Times in 6,220 Posts
    You have to submit to the repository that supplies the translation.

    You have done the Vix core one. Thanks

    AutoTimer is here
    https://github.com/oe-alliance/enigm...ster/autotimer

    Others will be here somewhere here:
    https://github.com/oe-alliance
    https://github.com/oe-alliance/oe-alliance-plugins

    If you can't find it/them, on your internet search, use "github oe-alliance (plugin name)"

    Once you fork, best to create a new branch which can be deleted afterwards. Keeping your fork in sync using the web is not very well documented. However using applications such as Sourcetree is easier to do.

    As you are uploading to the GitHub website, each "transaction" comes up as a commit. When submitting a pull request, they come up with repeat entries. There isn't a way to do it in one go on the website. However, you can edit them. No point having two entries of "Add files via upload ". I have edited the pull requests for you prior to merging the two you have submitted.

  3. The Following User Says Thank You to abu baniaz For This Useful Post:

    Kojo_ (03-06-18)

  4. #3
    abu baniaz's Avatar
    Title
    Moderator
    Join Date
    Sep 2010
    Location
    East London
    Posts
    23,317
    Thanks
    6,410
    Thanked 9,142 Times in 6,220 Posts
    Another tip for you to consider, when you click on compare and prior to submitting the pull-request, you have opportunity to change the pull request title.

    "[Autotimer] Update Finnish translation" is better than

    "Add files via upload"

    Nothing major, just makes it clearer when people look at the history without checking every commit.
    https://github.com/oe-alliance/enigm...commits/master

  5. The Following User Says Thank You to abu baniaz For This Useful Post:

    Kojo_ (08-06-18)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
This website uses cookies
We use cookies to store session information to facilitate remembering your login information, to allow you to save website preferences, to personalise content and ads, to provide social media features and to analyse our traffic. We also share information about your use of our site with our social media, advertising and analytics partners.