VPS geht nicht [Archive] - Satellite Support Forum .: Home of OpenViX Team:.

Togora

05-12-20, 12:40

Hallo, Ich kann ein klein bissen Deutsch aber ich glaube viele hier kann das nicht. Gibt es kein forum fuer Deutsche kunden in Deutsche sprache? Ich habe meine kiste gestern bekommen und verstehe nicht was VPS bedautet. Ist das ein plugin oder was? When du das erklaeren kann dann versuche ich du zu helfen. Bis Bald

goRt

05-12-20, 20:19

VPS is a plugin for accurate recording, there's a longer thread about the issue in English

https://www.world-of-satellite.com/showthread.php?63409-5-4-001-VPS-plugin-Bootloop

Sent from my IN2013 using Tapatalk

foxcat

01-02-21, 13:07

Hallo, geht leider immer noch nicht wieder, Schade!

goRt

01-02-21, 17:31

Hallo, geht leider immer noch nicht wieder, Schade!Correct, a change was made to openvix which caused the issue so openvix is now waiting for the VPS Dec to fix his code to accommodate

Sent from my IN2013 using Tapatalk

goRt

03-02-21, 13:56

There is a workaround, if you go to VPS settings and change "VPS enabled by default" to NO, then you get VPS in add new timer (VPS functions correctly with autotimers)

foxcat

15-02-21, 16:34

Hallo, VPS wird zwar so Angezeigt, die Steuerung geht aber nicht, Leider! Das Problem geht nicht zu Umgehen.

Grüße

Joe_90

15-02-21, 16:43

The "edit timer" function does not handle the VPS setting. After editing, the value is unset. Only AutoTimer works correctly and sets the timer.xml (and timers_vps.xml) properly.

Google translate:

Die Funktion "Timer bearbeiten" verarbeitet die VPS-Einstellung nicht. Nach der Bearbeitung wird der Wert nicht gesetzt. Nur der automatische Timer funktioniert ordnungsgemäß und stellt die Datei timer.xml (und die Timer vps.xml) ordnungsgemäß ein.

BrokenUnusableAccount

15-02-21, 22:27

Changes have been made so that it should be working again in OpenViX 5.4.007 when it is released.

Joe_90

16-02-21, 02:23

The edit timer function does not work in that it does not save the VPS setting.

birdman

16-02-21, 02:41

The edit timer function does not work in that it does not save the VPS setting.The reason for that is that the TimerEntry code is in the images and there is no code in Vix (and Pli, ATV, ... as far as I know) to add it in.

There is code in the AutoTimer as that is also a plugin, and knows about the VPS plugin.

I'm (slowly) looking into it.

Joe_90

16-02-21, 12:29

Thanks birdman. I'm just reminding others that the only way to get VPS working is to use the AutoTimer function. Actually, AutoTimer can mess with VPS when it comes to recording an event. What VPS does when it is preparing a recording is that it modifies the start time in timers.xml by advancing it a minute ahead of actual time if it hasn't seen the event change flag. This holds off the start of the recording. It keeps advancing the start time until it sees the flag and then it sets the start time before the current real time and this triggers the recording to start immediately. This works pretty well most of the time. However, if the AutoTimer interval expires (default 30 minutes) during this period when VPS is advancing the start time, it may alter the start time to the original scheduled start time which may be in the past and the recording will start immediately. I have had this happen a couple of times. It's not a big deal as the effect is to have a longer padding before the programme starts. VPS will hold off the end of the recording until it sees the next programme flag. I suppose there is a possibility that AutoTimer could mess with the end of the recording, but my AutoTimer interval is set to 75 minutes, so I haven't actually seen any issues in that regard. Apologies for the ramble, but just to confirm that VPS works pretty well on 28.2 sat and terrestrial for me using AutoTimer or instant record. Manual timer setting doesn't work.

birdman

16-02-21, 12:44

Apologies for the ramble, but just to confirm that VPS works pretty well on 28.2 sat and terrestrial for me using AutoTimer or instant record. Manual timer setting doesn't work.That's why I'm not rushing.
It appears to work as well as it ever did, and at least the on/off setting now sticks.

ccs

16-02-21, 12:45

There's also a safe-mode option which could complicate things a bit as well, you keep your original pre and post padding start and stop times, and VPS will adjust at either end if needed.

Joe_90

16-02-21, 14:15

Yep ccs - the safe mode option makes the recording start at your initially selected time at the latest and I assume it extends the recording at the end. I haven't really used the safe option as I wanted to see how reliable it was. Channel 5 is a bit niggly as sometimes they start the programme before the event running flag is set in the EIT. It's usually only 30 seconds or so but that is down to the broadcaster's playout equipment. In the case of Channel 5 it seems to be triggered by the scheduled clock time. The Irish terrestrial service (Saorview) is the same - event flags change at the EPG schedule time, so if there is a delay in the actual programme start you may miss the end.

goRt

16-02-21, 21:10

The reason for that is that the TimerEntry code is in the images and there is no code in Vix (and Pli, ATV, ... as far as I know) to add it in.

There is code in the AutoTimer as that is also a plugin, and knows about the VPS plugin.

I'm (slowly) looking into it.But it was working in Vix prior to 5.4.0

Also VPS can be added using "edit timer" in the web if to create a new timer

Sent from my IN2013 using Tapatalk

birdman

17-02-21, 02:07

But it was working in Vix prior to 5.4.0There is no code to do it, and no sign of there ever having been any.

Also VPS can be added using "edit timer" in the web if to create a new timerWhich is unrelated to the menus within Vix itself.

goRt

17-02-21, 05:03

There is no code to do it, and no sign of there ever having been any.

Which is unrelated to the menus within Vix itself.I don't wish to appear rude, but there were a lot of version control issues on the other thread, and it remains fact that up until 5.4.x VPS 1.3 did not have these issues

Sent from my IN2013 using Tapatalk

ccs

17-02-21, 12:18

There is no code to do it, and no sign of there ever having been any.

I couldn't find any either (that's not saying much), but I've tried 5.3.039 and setting a timer from epg/green works, enable vps=yes sticks and the vps.xml file is created.

In the next release, 5.4.001 vps doesn't stick, as is currently being reported.

Maybe the vps plugin isn't linking into the add timer interface properly anymore, but still works for autotimers?

ccs

17-02-21, 13:36

I've just flashed 5.4.001 without any settings restores and as expected, the epg/green problem still exists.

When I downloaded the vps plugin, am I right in saying that I got the current latest version, and the same would have applied when I was on 5.3.039 ??

If that's the case, the plugin works, but something has changed in ViX. Maybe I'm stating the obvious.

It was this commit I was trying to exclude from the equation....

https://github.com/oe-alliance/enigma2-plugins/commit/d6c0614d4800e21eaa1217f7f6813914991393e2#diff-acb2a8e7c90345f066d741fc839397cd3c3eca93d364bb344f 324ec6bd478890

Trying to remove the commit doesn't work because I get into the boot loop which it fixes !

birdman

17-02-21, 13:56

I don't wish to appear rudeYou're not, so don't worry.

and it remains fact that up until 5.4.x VPS 1.3 did not have these issues Quite possibly.
All I meant was that i can't find any code that would have put it it into the menu.
But if it was there, it was there and I'm not looking in the right place, or hard enough, or hard enough.

birdman

17-02-21, 13:59

It was this commit I was trying to exclude from the equation....

https://github.com/oe-alliance/enigma2-plugins/commit/d6c0614d4800e21eaa1217f7f6813914991393e2#diff-acb2a8e7c90345f066d741fc839397cd3c3eca93d364bb344f 324ec6bd478890That doesn't change any functionality. It just "corrects" parameter passing so that it works on ATV and Vix.

However, its possible that the changes in Vix(?) which led to it being required might have caused a difference.

Joe_90

17-02-21, 14:00

Good detective work ccs! Maybe that commit broke the compatibility with the manual timer while fixing the boot loop issue? In which case, this info needs to be moved into the main VPS thread as it may get lost here.

ccs

17-02-21, 14:16

.... early days yet. :)

This is the bootloop thread .... https://www.world-of-satellite.com/showthread.php?63409-5-4-001-VPS-plugin-Bootloop&highlight=vps+bootloop

which has a reference to this commit....

https://github.com/OpenViX/enigma2/commit/468bd9cbfadd69d4138aac2b4fd8bfc12d4b3821

Joe_90

17-02-21, 14:33

I read that thread at the time and referenced it subsequently but I had never used (or heard of!) VPS before that. There has been a lot of work done on menus and cleaning up code between 5.3 and 5.4, plus the Python 3 stuff which may well have affected the manual timer functionality with VPS.

birdman

17-02-21, 17:40

This is the bootloop thread .... https://www.world-of-satellite.com/showthread.php?63409-5-4-001-VPS-plugin-Bootloop&highlight=vps+bootloop

which has a reference to this commit....

https://github.com/OpenViX/enigma2/commit/468bd9cbfadd69d4138aac2b4fd8bfc12d4b3821And nowhere in that does the text "vps" (in any case) occur, so I can't see that removing anything to do with VPS.

The specific sort of code I'm referring to is code that adds a vps entry to a menu. AutoTimerEntry has it, TimerEntry does not.

ccs

17-02-21, 18:26

And nowhere in that does the text "vps" (in any case) occur, so I can't see that removing anything to do with VPS.

The specific sort of code I'm referring to is code that adds a vps entry to a menu. AutoTimerEntry has it, TimerEntry does not.

But that's the commit which caused this vps fix to be needed to prevent the bootloop, mentioned in post #22.

https://github.com/oe-alliance/enigma2-plugins/commit/d6c0614d4800e21eaa1217f7f6813914991393e2#diff-acb2a8e7c90345f066d741fc839397cd3c3eca93d364bb344f 324ec6bd478890

All I know is that installing vps creates an extra (vps) option in add timer, all that fails is the save timer, the new option value is lost.

birdman

18-02-21, 00:01

But that's the commit which caused this vps fix to be needed to prevent the bootloop, mentioned in post #22.But "only" because that PR changed the API for a function which the VPS plugin intercepts. So it was now being called with 0 parameters but was defined to expect 1.
Python does not like this.
This PR adds a default one (widget="config") and then checks how many to has to pass to the call it intercepted.
It didn't change any functionality or options in menus.

ccs

18-02-21, 12:20

@goRt

On 5.3.xxx does enabling VPS by default like this...

61512

get passed thru to an epg/green add timer, as I'm not seeing it...

61513

ronand

18-02-21, 12:42

I have been testing 5.3 briefly. ADD TIMER from epg does work - although with a bit of a fudge. VPS Enabled by Default doesn't seem to stick as already noted. When you enable it manually in the new timer entry the VPS check fails (because the flag is not there) and it sets it as YES (SAFE MODE) which is pointless as the look ahead feature does not kick in. Then you need to change the VPS (Safe Mode) to YES and the VPS recording will function correctly.

ccs

18-02-21, 12:51

.... am I right in saying that flashing 5.3.xxx and then installing VPS will get the same version currently on the feeds for 5.4.xxx ??

Or to put in another way, are there still separate plugin feeds for 5.3.xxx ??

I'm not convinced I'm comparing the "working" version in 5.3 with the version in 5.4.

ronand

18-02-21, 12:58

Its a separate plugin feed for 5.3

ccs

18-02-21, 13:14

Thanks, I've just realised that if I'd looked in SystemPlugins/vps I'd have seen that all the files were created at the same time as the last 5.3 release.

Joe_90

18-02-21, 14:04

Its a separate plugin feed for 5.3

But, is it the same VPS plugin code? i.e. - are we encountering changes in both VPS code and manual timer handling in 5.4 or is it just down to menu/timer interface handling in ViX?

edit - or maybe that's what ccs meant (that the VPS files are the same in 5.3 and 5.4):confused:

ccs

18-02-21, 14:15

edit - or maybe that's what ccs meant (that the VPS files are the same in 5.3 and 5.4):confused:

That's what I was trying to understand, comparing 5.3 and 5.4 was becoming a nightmare, particularly with gui menu changes added to the equation.

The VPS plugin in 5.4 includes all the recent changes, the plugin files in 5.3 are all dated 19/07/2020.

Joe_90

18-02-21, 15:15

Sorry forgot that birdman had edited some of the VPS code to correct parameter handling.

goRt

18-02-21, 16:25

@goRt

On 5.3.xxx does enabling VPS by default like this...

61512

get passed thru to an epg/green add timer, as I'm not seeing it...

61513Yes, worked without issue on 5.3.xxx
Always set to default full control, turns on/off in manual timers
Displays v1.3 in the about panel.

Sorry for the delay in responding, I don't get notified on this thread (addressing now)

Sent from my IN2013 using Tapatalk

ccs

18-02-21, 16:37

Just to be clear, if I create a one off timer in 5.3 with VPS enabled by default (via the plugin men), the initial timer dialogue has VPS set to No, is that what you're seeing?

I'd have expected it to be Yes.

goRt

18-02-21, 16:40

ccs

18-02-21, 16:42

No idea then why I see different, I'll start again from scratch.

ccs

18-02-21, 17:41

No idea then why I see different, I'll start again from scratch.

Tried again and even went back to 5.3.020, but I still can't get a one off timer to default to vps=on when it's been setup to do so via the plugin menu.

birdman

18-02-21, 17:54

ccs

18-02-21, 18:15

Discussing what did and didn't happen in 5.3 is fairly moot.

We're looking at 5.4.

In 5.4 it will show up in AutoTimers, (as there is code to put it into the menu) whereas in Timers it won't (as there is no such code).

So the only was that 5.3 can come into it is see whether any code relating to VPS was removed between there and 5.4.

I do understand that. But what does/doesn't work between releases kind of makes sense to me, and I'm seeing different scenarios to others.

It's often easier to see what is there, rather than what isn't.

birdman

18-02-21, 18:32

I've just downloaded and old 5.3.020 (openvix-5.3.020.001.developer-et8000_usb.zip) and unpacked it.

I then searched for all files containing the string "vps" in ANY case.

[gmllaptop]: find -type f -name '*.pyo' | xargs grep -li vps
./usr/lib/enigma2/python/Plugins/Extensions/AutoTimer/AutoTimerComponent.pyo
./usr/lib/enigma2/python/Plugins/Extensions/AutoTimer/AutoTimer.pyo
./usr/lib/enigma2/python/Plugins/Extensions/AutoTimer/AutoTimerEditor.pyo
./usr/lib/enigma2/python/Plugins/Extensions/AutoTimer/AutoTimerResource.pyo
./usr/lib/enigma2/python/Plugins/Extensions/AutoTimer/AutoTimerConfiguration.pyo
./usr/lib/enigma2/python/Plugins/Extensions/OpenWebif/controllers/i18n.pyo
./usr/lib/enigma2/python/Plugins/Extensions/OpenWebif/controllers/views/responsive/ajax/at.pyo
./usr/lib/enigma2/python/Plugins/Extensions/OpenWebif/controllers/views/responsive/ajax/edittimer.pyo
./usr/lib/enigma2/python/Plugins/Extensions/OpenWebif/controllers/views/ajax/at.pyo
./usr/lib/enigma2/python/Plugins/Extensions/OpenWebif/controllers/views/ajax/edittimer.pyo
./usr/lib/enigma2/python/Plugins/Extensions/OpenWebif/controllers/models/timers.pyo
./usr/lib/enigma2/python/Plugins/Extensions/OpenWebif/controllers/web.pyo
./usr/lib/enigma2/python/Plugins/Extensions/OpenWebif/controllers/ajax.pyoSo nothing there to put anything into a Timer menu. Just the unrelated code for AutoTimer and OpenWebIF.
And nothing (significant) changed in the VPS plugin between Sep 2017 and Oct 2020 (the bootloop fix, which is also nothing ot do with menu entries).

birdman

18-02-21, 18:37

I do understand that. But what does/doesn't work between releases kind of makes sense to me, and I'm seeing different scenarios to others.But it's of no use to me as I can't see how what is being described could have worked with the current code, or with the code I can see that was around for 5.3.

Is (was) there another VPS plugin somewhere?

goRt

18-02-21, 18:40

But it's of no use to me as I can't see how what is being described could have worked with the current code, or with the code I can see that was around for 5.3.

Is (was) there another VPS plugin somewhere?

I'll restore my image and tell you in 10 mins

goRt

18-02-21, 18:46

Solo4k OpenViX 5.3.039 (2020-07-19)
enigma2-plugin-systemplugins-vps (5.3+git6850+5bbb4eb-r0)
systemplugins-vps

birdman

18-02-21, 19:24

The is a PartnerBox plugin which enables VPS in timers.

birdman

18-02-21, 19:59

The VPS plugin does intercept the TimerEntry createSetup() call.

Which is (presumably) why it shows up when editing a Timer set up by an AutoTimer.

So the question is why it doesn't show up for a stand-alone Timer.

I'm looking now....

Looks as though the code change that led to the boot loop (not the fix...) might have changed something.

< 8882.2884> 18:55:55.5307 ('[VPS-Plugin] VPS-plugin error:', AttributeError("'TimerEntry' object has no attribute 'session'",))
< 8882.2886> 18:55:55.5309 Traceback (most recent call last):
< 8882.2888> 18:55:55.5311 File "/usr/lib/enigma2/python/Plugins/SystemPlugins/vps/Modifications.py", line 152, in new_TimerEntry_createConfig
< 8882.2899> 18:55:55.5322 elif config.plugins.vps.vps_default.value != "no" and self.timer.eit is not None and self.timer.name != "" and self.timer not in self.session.nav.RecordTimer.timer_list and self.timer not in self.session.nav.RecordTimer.processed_timers:
< 8882.2902> 18:55:55.5326 AttributeError: 'TimerEntry' object has no attribute 'session'

PS: This looks like progress.

birdman

18-02-21, 20:27

I might have a (1-line) solution.

Just have to ask a question of the author(s) of that change.

Huevos

18-02-21, 22:07

Which change?

birdman

18-02-21, 22:10

Which change?

https://github.com/OpenViX/enigma2/commit/04f7701db4b5f42c393029119be905be97acb49a#diff-cb3c1e4116eb33ab0259981c4e00e40397eb470ef158671ddc 07189fd5fd0645

The question is in the comments.

Huevos

18-02-21, 22:24

Have you tried adding "self.session = session" in the __init__() to see if it fixes the problem?

birdman

18-02-21, 23:31

Have you tried adding "self.session = session" in the __init__() to see if it fixes the problem?Yes, as I noted in the comments section to the PR.

I need to know whether there was a good reason that the session parameter was ignored or if it was just an oversight.

Huevos

19-02-21, 00:03

I sent him a message.

Huevos

19-02-21, 00:58

Gordon, where in the VPS code is TimerEntry ever instantiated?

birdman

19-02-21, 00:59

Weird.
Having got that traceback report I've changed something somewhere (in my VPS config?) and it has gone away.

EDIT: It's back. So there ARE two issues.

I now get another one - which may be the "real" problem:

< 3774.5392> 23:53:38.8733 Traceback (most recent call last):
< 3774.5394> 23:53:38.8735 File "/usr/lib/enigma2/python/Plugins/SystemPlugins/vps/Modifications.py", line 200, in new_TimerEntry_createSetup
< 3774.5397> 23:53:38.8738 self.timerVps_enabled_Entry = getConfigListEntry(_("Enable VPS"), self.timerentry_vpsplugin_enabled)
< 3774.5399> 23:53:38.8740 AttributeError: 'TimerEntry' object has no attribute 'timerentry_vpsplugin_enabled'

(although given my ability to find real bugs in the wrong places, it might not be).

birdman

19-02-21, 01:46

EDIT: It's back. So there ARE two issues.If VPS is enabled (== not No) you get both failures.
If it is off you only get the second.

Joe_90

19-02-21, 02:08

Everything to do with the settings in the VPS plugin cause issues elsewhere. Try turning on the "wake from standby" setting (I'm paraphrasing as I don't have a device active) in the VPS config menu. When the device boots it doesn't go into standby; it activates a tuner and leaves it active. My normal PowerTimer settings to deep shut down the box if it is 20 minutes in standby won't work as the box remains active. In order to get unattended recordings to work I leave the "wake from standby" setting off in the VPS config and just let the normal timer settings wake the box from deep standby.

birdman

19-02-21, 02:30

Everything to do with the settings in the VPS plugin cause issues elsewhere.There are current issues with the code, so don't be surprised that there are other problems.

Try turning on the "wake from standby" setting (I'm paraphrasing as I don't have a device active) in the VPS config menu. When the device boots it doesn't go into standby;The same can be true about running a recording. Some (many/most/all) boxes do not know why they have woken up and have to make a guess. It can be wrong.

My normal PowerTimer settings to deep shut down the box if it is 20 minutes in standby won't work as the box remains active.No idea what this is meant to be doing. Let's solve the problems one at a time.

In order to get unattended recordings to work I leave the "wake from standby" setting off in the VPS config and just let the normal timer settings wake the box from deep standby.Unless you expect a programme to suddenly be brought forward, this strikes me as a sensible way to run anyway.

birdman

19-02-21, 02:33

Anyway, back to why there is no VPS option in one-off timers.

Part of the problem had been tracked down.

I'm working on a solution - which is 1 line in Vix (but where it would be "out of place") and somewhat more than that in the plugin (which is the place that has caused the requirement).

birdman

19-02-21, 03:25

I'm working on a solution.I think I have one. ("It works for me")
You'll need to wait until later today to find out what it is - it's getting late...

EDIT: Working on instant records too.

birdman

19-02-21, 11:31

Here is the "fixed" code.

61520

(goes in /usr/lib/enigma2/python/Plugins/SystemPlugins/vps)

I'd be grateful if others could check it.
In particular I'd like it to be checked on OpenATV - as that still uses the original createSetup() call and so has no TimerBaseEntry.

birdman

19-02-21, 11:54

The problem was that the "[(Power)TimerEntry] Refactor to use common base classes" change added a TimerBaseEntry class whose createConfig() needs to be called before Setup.__init__() is called.

But the VPS plugin ends up intercepting the createConfig() call in TimerEntry and expects self.session to have been set after it calls the original code - but it no longer is.
Not only that, the createConfig() call doesn't actually have access to the session parameter, so can't fudge it in.

The 1-line solution I mentioned was to modify Vix enigma2 code to set self.session in TimerEntryBase.__init__(), but that is rather messy as Vix has no reason at all to do that - it's already calling the correct code to set things correctly for Vix.

The solution is to check whether TimerEntryBase exists (if it doesn't, which is the case on OpenATV, the original code still works) and if so, intercept the TimerEntryBase.__init__() call and set self.session there.
Which puts the setting where it is needed - in the plugin.

ccs

19-02-21, 12:04

birdman

19-02-21, 12:42

I've had a quick try with default vps settings, add timer epg/green still not remembering enable vps=yes, using 5.4.007.009

The vps.xml file gets created, but hasn't been updated since the first attempt.True.

But at least the option was available in a one-off timer for you to get this far, so still progress.

ccs

19-02-21, 12:46

True.

But at least the option was available in a one-off timer for you to get this far, so still progress.

The option was always there but you couldn't change its value.

birdman

19-02-21, 13:05

The option was always there but you couldn't change its value.No, in 5.4 you couldn't see the option with a one-off timer.

timers_vps.xml is the file it should be written to, but when that gets written no timer has vps enabled...

ronand

19-02-21, 13:08

Testing on 5.4.006 (release) on a H7. Set up a one-off recording from the epg. VPS option is there (and was set to NO). Changed it to YES to enable and it fails the vps check as expected. But it is switching back to NO unlike on 5.3 where it does stick.

ccs

19-02-21, 13:21

No, in 5.4 you couldn't see the option with a one-off timer.
I've just removed and reinstalled the release version on vps on 5.4 Epg/Green .......

61524

If you setup the vps plugin like this it doesn't show the option in epg/green...

61525

So we're both right. :)

nb settings file keeps vps options after uninstalling the plugin.

Joe_90

19-02-21, 13:29

No, in 5.4 you couldn't see the option with a one-off timer.

timers_vps.xml is the file it should be written to, but when that gets written no timer has vps enabled...

You can see the option in a one-off timer providing you have the "VPS enabled by default" set to no in the plugin settings. But, as @ccs posted, any value set in the timer menu was not saved.

birdman

19-02-21, 13:38

nb settings file keeps vps options after uninstalling the plugin.I don't think anything removes options when something is removed.
The only thing that could remove "old" options is the package itself, and it can't a enigma2 is (possibly) running so has them "active".

ccs

19-02-21, 13:41

I don't think anything removes options when something is removed.
The only thing that could remove "old" options is the package itself, and it can't a enigma2 is (possibly) running so has them "active".

OK, but it can catch you out when you reinstall a plugin and epg/green no longer shows the option being discussed.

(Until you put back the original default.)

birdman

19-02-21, 13:48

You can see the option in a one-off timer providing you have the "VPS enabled by default" set to no in the plugin settings. But, as @ccs posted, any value set in the timer menu was not saved.OK.

But were in danger of losing track of what is and is not working if every change for point A gets a comment about each of points B to Z as well.

So can we agree that the fix does get the item back into the menu, but the following issues now exist:

The VPS option doesn't appear in the Timer Edit menu if the VPS plugin config is set to "enabled by default"
Changing the VPS option in the Timer Edit menu doesn't actually get set/stick in the timer

The latter seems to be the result of there being no code to actually pass on the change to the write-out function.

Huevos

19-02-21, 13:50

nb settings file keeps vps options after uninstalling the plugin.This is normal.

ccs

19-02-21, 13:53

OK.

But were in danger of losing track of what is and is not working if every change for point A gets a comment about each of points B to Z as well.

So can we agree that the fix does get the item back into the menu, but the following issues now exist:

The VPS option doesn't appear in the Timer Edit menu if the VPS plugin config is set to "enabled by default"
Changing the VPS option in the Timer Edit menu doesn't actually get set/stick in the timer

The latter seems to be the result of there being no code to actually pass on the change to the write-out function.

That's what I was seeing without your latest change to Modifications.py

Huevos

19-02-21, 13:53

The latter seems to be the result of there being no code to actually pass on the change to the write-out function.What is the name of that variable.

Joe_90

19-02-21, 14:12

OK.

But were in danger of losing track of what is and is not working if every change for point A gets a comment about each of points B to Z as well.

So can we agree that the fix does get the item back into the menu, but the following issues now exist:

The VPS option doesn't appear in the Timer Edit menu if the VPS plugin config is set to "enabled by default"
Changing the VPS option in the Timer Edit menu doesn't actually get set/stick in the timer

The latter seems to be the result of there being no code to actually pass on the change to the write-out function.

Your two bullet points are correct. But that has been the case all along (in 5.4 since I started testing VPS), it's not a new phenomenon.

Rob van der Does

19-02-21, 16:27

You can see the option in a one-off timer providing you have the "VPS enabled by default" set to no in the plugin settings.

That makes sense to me; if VPS is enabled by default, there's no need to see the option.
Or is there?

ccs

19-02-21, 16:34

That makes sense to me; if VPS is enabled by default, there's no need to see the option.
Or is there?

There is if you want to switch the option off for a particular channel.

ccs

19-02-21, 16:46

I've just added the patch again, and now epg/green shows the Enable VPS option=No, whether Enable VPS in the plugin is set to yes or no. :confused::confused:

Joe_90

19-02-21, 17:55

Rob - as ccs says, you may want to switch off the VPS setting in the timer. In an AutoTimer, the option to use VPS is controllable.

birdman

19-02-21, 20:19

Your two bullet points are correct. But that has been the case all along (in 5.4 since I started testing VPS), it's not a new phenomenon.I know, which was why I was telling you all not to mention it.

ALL I'm trying to confirm at the moment is that the fix I have made works - which is ONLY to get the VPS entry to show up on manual timer (and instant records) which it was not doing previously (at 5.4. Please do NOT mention 5.3).
Of course now it is there is will exhibit the other problems.

I'm trying to solve the issues in small steps, so that I can commit individual PRs. (Even God apparently took 6 days to piece the universe together, not do it all in one go....)

birdman

19-02-21, 20:20

That makes sense to me; if VPS is enabled by default, there's no need to see the option.
Or is there?Yes.
Otherwise it's not a default - it's a forced-on option. Totally different.

birdman

19-02-21, 20:24

What is the name of that variable.I don't know, because it's not there. At least not that I can see.
But I'm proceeding through the known problems one at a time.
The next one I'm going to look at is why the VPS option doesn't show up when you have "Default On" set. My suspicion is that this is an incorrect use of the word Default. I reckon it makes more sense to always put the option in the menu and have the Default determine the starting value.
And whilst looking into this I may find out what the code is trying to do as, so far, I haven't had time to figure that out.

Joe_90

19-02-21, 23:33

There are quite a number of issues with English translation from German(I presume) in the note for the plugin which makes the program description difficult to understand. It's possible the "Default On" setting in the VPS config menu means that the entry in the timer menu should read "VPS yes". It's difficult to ascertain or there is ambiguity in working out what the author actually meant. As regards the instant records, that has always offered the VPS option in 5.4 prior to any of your changes.

birdman

20-02-21, 12:52

I've submitted a PR (well, two - one for master and another for dev) for this.

https://github.com/oe-alliance/enigma2-plugins/pull/412
https://github.com/oe-alliance/enigma2-plugins/pull/413
Now I can sit down with a listing and pen to sort out what this thinks it is doing.

Joe_90

20-02-21, 14:04

I downloaded VPS from my ATV image and ran some tests. Manual timer entry has VPS option available and it saves it properly (Yes/No/Yes safe-mode). Actual recordings are as expected - start and stop on EIT programme boundaries in strict mode and obey user padding in safe-mode.

birdman

20-02-21, 17:19

I downloaded VPS from my ATV image and ran some tests. Manual timer entry has VPS option available and it saves it properly (Yes/No/Yes safe-mode).Yes.
I can believe that, given what I read ~2mins ago....

The VPS plugin traps a keyGo() function, which it expects to be called when a timer is saved, and this causes it to set things up to be put into the timer_xps.xml file.

However, the Timer refactoring code deprecated keyGo() in favour of keySave(). And whereas TimerEntryBase does re-route keyGo() calls to keySave(), the key-press in the menu is bound to keySave().
So currently the VPS menu entry code is skipped in Vix on saving the entry, which explains why it is ignored.

Should be(?) a trivial fix - keyGo() and keySave() have identical calling sequences - it's just a name change.

EDIT: Yes, it was trivial. And would have been even quicker had I not left in a failing debug line I added yesterday. My timers_vps.xml file is now being updated.

<?xml version="1.0" ?>
<vps_timers>
<timer begin="1613840400" end="1613841900" serviceref="1:0:19:A010:A000:233A:EEEE0000:0:0:0:" vps_enabled="1" vps_overwrite="1" vps_time="0">
</timer>
<timer begin="1613840401" end="1613841900" serviceref="1:0:1:1C00:104D:233A:EEEE0000:0:0:0:" vps_enabled="1" vps_overwrite="0" vps_time="0">
</timer>
</vps_timers>

EDIT2: PR submitted:

https://github.com/oe-alliance/enigma2-plugins/pull/414

birdman

20-02-21, 18:03

For anyone interested, this is the updated file:

61543

birdman

20-02-21, 18:08

So can we agree that the fix does get the item back into the menu, but the following issues now exist:

The VPS option doesn't appear in the Timer Edit menu if the VPS plugin config is set to "enabled by default"
Changing the VPS option in the Timer Edit menu doesn't actually get set/stick in the timer

The latter seems to be the result of there being no code to actually pass on the change to the write-out function.I've just fixed the latter of these. VPS timers are now saved.
Having done so I can't reproduce the former.

Whatever I set for "VPS enabled by default" shows up as the VPS setting for any newly-created timer. Of course, any exisiting timer will keep the setting it has when saved.

Joe_90

20-02-21, 18:32

Thanks birdman - I'll test asap!

EDIT - Worked fine on a manual record, thanks birdman.

ronand

20-02-21, 18:47

That seems to be working fine for a single recording from epg on 5.4.007 (release)

goRt

20-02-21, 19:38

Also working fine on a single recording, autotimers also seem to have set correctly

Sent from my IN2013 using Tapatalk

ccs

20-02-21, 20:05

Everything looks ok except the ability to setup an autotimer to use safe-mode.

The option can be set in the vps plugin, but neither epg/blue to create an autotimer, nor a change of autotimer defaults has the safe-mode choice, just yes or no.

Not sure what the plugin option actually achieves, manual timers need changing to safe-mode if that's what you want.

goRt

20-02-21, 20:07

Joe_90

20-02-21, 20:11

I haven't come across a situation where "safe-mode" is any different to normal recording with padding before and after an event. I suppose if an event start was delayed by (say) 10 minutes and your default padding after an event was (say) 5 minutes, then "safe-mode" should theoretically hold off the recording end for the 10 minutes. I just haven't seen that happen yet. I'm living dangerously with BBC/ITV/C4 recording and letting the broadcaster control the start/end :fart2:

ronand

20-02-21, 20:12

I don't use safe mode as that doesn't seem to use the "look ahead" feature so is pretty pointless.

ccs

20-02-21, 20:13

I think safe or not is the next line in the autotimer - control recording completely by service.

I'd tried that, but the timer(s) created just had Enable VPS=Yes (which could then be changed to safe-mode, but that's too late).

ccs

20-02-21, 20:15

I don't use safe mode as that doesn't seem to use the "look ahead" feature so is pretty pointless.

It does use look ahead, but starts recording based on the original start time, so you get a recording even when it misses the now and next transition.

So channels which don't comply still work.

goRt

20-02-21, 20:17

I'd tried that, but the timer(s) created just had Enable VPS=Yes (which could then be changed to safe-mode, but that's too late).It used to function how I described
It should have been a 3 stage switch for consistency as per the timers

Sent from my IN2013 using Tapatalk

ccs

20-02-21, 20:42

.... I should have looked in the vps.xml file, maybe that sets safe mode as expected, but it's too late now, I'm back to a standard image.

ronand

20-02-21, 20:59

I've been testing it in the release version (5.4.007). If the soaps don't get recorded properly I won't be getting upset.

birdman

20-02-21, 21:31

I think safe or not is the next line in the autotimer - control recording completely by serviceCorrect.
This controls the value of vps_overwrite, which is the variable used for safe mode. (If vps is off it is ignored).

birdman

21-02-21, 05:21

Hmmm....it seems that my work here may be done.

I only originally looked because a crash mentioned a feature I'd added (3 years ago?).
That was a failure by the plugin to pass on parameters in an agnostic/generic way.
Now fixed.

Then there was a problem with a recently changed API in Vix that was silently trapped by a try/except clause to do nothing - not even mention the problem.
Fixed (although, to be fair, it still wouldn't report failures).

Then it was found that the same API change had resulted in a third piece of code never being reached at all.
Also fixed.

From what I gather the settings for VPS now work as intended?

goRt

21-02-21, 06:25