PDA

View Full Version : Small issue with ViXBMC_1080_Confluence skin in IMDB screen


smipx
05-04-20, 17:47
To the maker of this skin - a big thanks. Loving it :-)

There is one small issue I have discovered on my copy of the skin (using OpenVix latest release and skin from built-in repository) - screen res set to 1080x1024

On the IMDB screen some of the text seems to be superimposed on itsself like this image below. Looks like the cast bit needs to move down a bit as it is being obliterated by the "season" and "Release date" info.
59844

I have looked at the code under the common directory inside the ...common.xml file:

<!-- ## IMDB ## -->
<screen name="IMDB" position="fill" flags="wfNoBorder" backgroundColor="transparent">
<panel name="FullScreenTemplate" />
<widget name="titellabel" position="22,10" size="850,50" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" valign="center" halign="center" transparent="1" zPosition="2" />
<widget name="statusbar" position="22,40" size="850,100" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" halign="left" valign="center" transparent="1" zPosition="2" />
<widget name="menu" position="22,140" size="850,800" font="menulist;34" itemHeight="50" foregroundColor="maincolour" backgroundColor="menubackground" scrollbarMode="showOnDemand" transparent="1" zPosition="2" />
<widget name="castlabel" position="22,140" size="850,800" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" transparent="1" />
<widget name="detailslabel" position="22,140" size="850,800" font="menulist;34" itemHeight="50" foregroundColor="maincolour" backgroundColor="menubackground" halign="center" valign="center" transparent="1" />
<widget name="extralabel" position="22,140" size="850,850" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" transparent="1" />
<widget name="ratinglabel" position="22,900" size="850,50" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" transparent="1" halign="left" valign="center" zPosition="2" />
<widget name="starsbg" pixmap="imdb/starsbar_empty.png" position="22,950" size="315,32" backgroundColor="menubackground" transparent="1" alphatest="blend" zPosition="2" />
<widget name="stars" pixmap="imdb/starsbar_filled.png" position="22,950" size="315,32" backgroundColor="menubackground" transparent="1" alphatest="blend" zPosition="3" />
<widget name="poster" position="1250,600" size="335,377" alphatest="blend" zPosition="2" />
<panel name="ButtonBar" />
</screen>


... but I'm not sure what to change as I don't want to F the whole thing up.

Can a more knowledgeable person please give me a pointer.


Thanks
Paul
abu baniaz
05-04-20, 17:54
Pointer 1 (will make your screenshots brilliant)
https://www.world-of-satellite.com/showthread.php?44054-How-to-take-screen-shots-How-to-attach-files

Pointer 2
You can alter the background colours to test them and see what is what. This will enable you to test and adapt.
birdman
05-04-20, 18:08
To the maker of this skin - a big thanks. Loving it :-)So do I. According to the comments at the top it was rossi2000, but I've made the recent changes to it.

I've seen a similar situation (with overwritten text) in another situation (waiting to spin up the disk for a recoding list?) but in that case it went away once the wait was over, and I couldn't track down what was allowing it, so left things as they were.
Perhaps I need to try harder now...
smipx
05-04-20, 18:52
Pointer 1 (will make your screenshots brilliant)
https://www.world-of-satellite.com/showthread.php?44054-How-to-take-screen-shots-How-to-attach-files

Pointer 2
You can alter the background colours to test them and see what is what. This will enable you to test and adapt.

Hi, Pointer 1 - noted :-)
Point 2. Good thinking - I think however I know the elements that are clashing but I'm not sure that if I change the x,y values whether that will muck it up. I guess i'll have to experiment. To my mind the
<widget name="castlabel" position="22,140" size="850,800" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" transparent="1" />
<widget name="detailslabel" position="22,140" size="850,800" font="menulist;34" itemHeight="50" foregroundColor="maincolour" backgroundColor="menubackground" halign="center" valign="center" transparent="1" />
<widget name="extralabel" position="22,140" size="850,850" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" transparent="1" />

all need moving down a touch perhaps to:

<widget name="castlabel" position="22,180" size="850,800" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" transparent="1" />
<widget name="detailslabel" position="22,180" size="850,800" font="menulist;34" itemHeight="50" foregroundColor="maincolour" backgroundColor="menubackground" halign="center" valign="center" transparent="1" />
<widget name="extralabel" position="22,180" size="850,850" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" transparent="1" />

I'll have a play tomorrow when the missus is not using it :-)
smipx
06-04-20, 09:53
so... in the end I changed it to the following and it sorted the issue.:

<!-- ## IMDB ## -->
<screen name="IMDB" position="fill" flags="wfNoBorder" backgroundColor="transparent">
<panel name="FullScreenTemplate" />
<widget name="titellabel" position="22,10" size="850,50" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" valign="center" halign="center" transparent="1" zPosition="2" />
<widget name="statusbar" position="22,40" size="850,100" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" halign="left" valign="center" transparent="1" zPosition="2" />
<widget name="menu" position="22,140" size="850,800" font="menulist;34" itemHeight="50" foregroundColor="maincolour" backgroundColor="menubackground" scrollbarMode="showOnDemand" transparent="1" zPosition="2" />
<widget name="castlabel" position="22,340" size="850,800" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" transparent="1" />
<widget name="detailslabel" position="22,140" size="850,800" font="menulist;34" itemHeight="50" foregroundColor="maincolour" backgroundColor="menubackground" halign="center" valign="center" transparent="1" />
<widget name="extralabel" position="22,140" size="850,850" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" transparent="1" />
<widget name="ratinglabel" position="22,900" size="850,50" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" transparent="1" halign="left" valign="center" zPosition="2" />
<widget name="starsbg" pixmap="imdb/starsbar_empty.png" position="22,950" size="315,32" backgroundColor="menubackground" transparent="1" alphatest="blend" zPosition="2" />
<widget name="stars" pixmap="imdb/starsbar_filled.png" position="22,950" size="315,32" backgroundColor="menubackground" transparent="1" alphatest="blend" zPosition="3" />
<widget name="poster" position="1250,600" size="335,377" alphatest="blend" zPosition="2" />
<panel name="ButtonBar" />
</screen>
abu baniaz
06-04-20, 10:16
Can you post a screenshot of new look please?
smipx
06-04-20, 12:24
Sure, This is how a program looks now.

59845
abu baniaz
06-04-20, 13:55
I have made the change here
https://github.com/OpenViX/skins/commit/7bf7c6c0ee5828727e2ffa2ca2be2494264d140b

Thanks for reporting as well as fixing

Pointer 3 (if you need it)
https://www.world-of-satellite.com/showthread.php?60570-GitHub-Creating-pull-requests
smipx
06-04-20, 16:37
:-)

Obviously I have not made full tests for all scenarios e.g. different resolutions, different font multipliers (in EPG you can increase font and I have all mine to +4 - not even sure that affects the IMDB screens though) etc. but for me its working good.

Nice one.

Paul
ccs
06-04-20, 18:53
Sure, This is how a program looks now.

59845
You're still getting some overlaps, this is what simple_1080 comes up with......
birdman
07-04-20, 02:38
You're still getting some overlaps, this is what simple_1080 comes up with......This is on my "to look at" list, but anything that makes it better, even if not perfect, is always welcome.
smipx
07-04-20, 09:34
Hi, You are quite right ccs. I'm no programmer (and will not make any more changes as the change below took hours of fiddling) but I have had a go at adding scrollbars to that screen and changing the window size. I think I have made some progress :-)

this is the code I have settled on for now and it seems to be a lot better:

<!-- ## IMDB ## -->
<screen name="IMDB" position="fill" flags="wfNoBorder" backgroundColor="transparent">
<panel name="FullScreenTemplate" />
<widget name="titellabel" position="22,10" size="850,50" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" valign="center" halign="center" transparent="1" zPosition="2" />
<widget name="statusbar" position="22,40" size="850,100" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" halign="left" valign="center" transparent="1" zPosition="2" />
<widget name="menu" position="22,140" size="850,800" font="menulist;34" itemHeight="50" foregroundColor="maincolour" backgroundColor="menubackground" scrollbarMode="showOnDemand" transparent="1" zPosition="2" />
<widget name="castlabel" position="22,420" size="850,470" font="menulist;32" itemHeight="50" foregroundColor="maincolour" scrollbarMode="showOnDemand" backgroundColor="menubackground" transparent="1" />
<widget name="detailslabel" position="22,140" size="850,800" font="menulist;34" itemHeight="50" foregroundColor="maincolour" backgroundColor="menubackground" halign="center" valign="center" transparent="1" /> <widget name="extralabel" position="22,140" size="850,850" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" transparent="1" />
<widget name="ratinglabel" position="22,900" size="850,50" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" transparent="1" halign="left" valign="center" zPosition="2" />
<widget name="starsbg" pixmap="imdb/starsbar_empty.png" position="22,950" size="315,32" backgroundColor="menubackground" transparent="1" alphatest="blend" zPosition="2" />
<widget name="stars" pixmap="imdb/starsbar_filled.png" position="22,950" size="315,32" backgroundColor="menubackground" transparent="1" alphatest="blend" zPosition="3" />
<widget name="poster" position="1250,600" size="335,377" alphatest="blend" zPosition="2" />
<panel name="ButtonBar" />
</screen>

Here is a screenshot of how it looks now:

59850


Hope that's all that was wrong :-)

Cheers,
Paul
ccs
07-04-20, 10:04
I've looked at skins before and found them totally baffling.:)


Just to be really boring, your last screenshot shows a rating of 6.5 out of 10, and the blue stars reflect that.

On my screen shot a rating of 7.7 has 10 yellow stars. Do the stars come straight from IMDB, or does the skin process the rating to give the stars?
smipx
07-04-20, 10:05
No idea mate. Assume so.
ccs
07-04-20, 10:15
I've managed to work it out (the easy way :)).

Simple_1080 gives "The Spiderwick Chronicle" 10 yellow stars, so it's a minor skin issue.
birdman
07-04-20, 13:14
I've managed to work it out (the easy way :)).

Simple_1080 gives "The Spiderwick Chronicle" 10 yellow stars, so it's a minor skin issue.That tells you there is a bug, but not which of the skins has a bug.
In fact both may have a bug
ccs
07-04-20, 13:41
I knew I should have said possibly in my last post. :)

Anyway, I thought it rang a bell....

https://www.world-of-satellite.com/showthread.php?60129-IMDb-all-films-get-10-stars!&highlight=IMDB+rating
smipx
07-04-20, 14:04
btw. I'm not on GitHub or anything (and don't plan to make any more changes so don't really want to register and learn that system as i'm not a programmer) so can someone who is please update Abu's changed code on there to:

<!-- ## IMDB ## -->
<screen name="IMDB" position="fill" flags="wfNoBorder" backgroundColor="transparent">
<panel name="FullScreenTemplate" />
<widget name="titellabel" position="22,10" size="850,50" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" valign="center" halign="center" transparent="1" zPosition="2" />
<widget name="statusbar" position="22,40" size="850,100" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" halign="left" valign="center" transparent="1" zPosition="2" />
<widget name="menu" position="22,140" size="850,800" font="menulist;34" itemHeight="50" foregroundColor="maincolour" backgroundColor="menubackground" scrollbarMode="showOnDemand" transparent="1" zPosition="2" />
<widget name="castlabel" position="22,340" size="850,800" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" transparent="1" />
<widget name="detailslabel" position="22,140" size="850,800" font="menulist;34" itemHeight="50" foregroundColor="maincolour" backgroundColor="menubackground" halign="center" valign="center" transparent="1" />
<widget name="extralabel" position="22,140" size="850,850" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" transparent="1" />
<widget name="ratinglabel" position="22,900" size="850,50" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" transparent="1" halign="left" valign="center" zPosition="2" />
<widget name="starsbg" pixmap="imdb/starsbar_empty.png" position="22,950" size="315,32" backgroundColor="menubackground" transparent="1" alphatest="blend" zPosition="2" />
<widget name="stars" pixmap="imdb/starsbar_filled.png" position="22,950" size="315,32" backgroundColor="menubackground" transparent="1" alphatest="blend" zPosition="3" />
<widget name="poster" position="1250,600" size="335,377" alphatest="blend" zPosition="2" />
<panel name="ButtonBar" />
</screen>

His link is here: https://github.com/OpenViX/skins/com...be2494264d140b

Not essential of course but his last change (based on my original try) is not so good and the code above is 100% better :-)

thanks folks.
Paul
smipx
07-04-20, 16:27
sorry that link should be https://github.com/OpenViX/skins/commit/7bf7c6c0ee5828727e2ffa2ca2be2494264d140b
abu baniaz
07-04-20, 17:11
Are you sure that is the code you want committed? All I can see is space being changed in front of z position.
smipx
07-04-20, 17:19
Hi Abu,

My bad - wrong code pasted. This is the code that makes is look like the image above.

<!-- ## IMDB ## -->
<screen name="IMDB" position="fill" flags="wfNoBorder" backgroundColor="transparent">
<panel name="FullScreenTemplate" />
<widget name="titellabel" position="22,10" size="850,50" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" valign="center" halign="center" transparent="1" zPosition="2" />
<widget name="statusbar" position="22,40" size="850,100" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" halign="left" valign="center" transparent="1" zPosition="2" />
<widget name="menu" position="22,140" size="850,800" font="menulist;34" itemHeight="50" foregroundColor="maincolour" backgroundColor="menubackground" scrollbarMode="showOnDemand" transparent="1" zPosition="2" />
<widget name="castlabel" position="22,420" size="850,470" font="menulist;32" itemHeight="50" foregroundColor="maincolour" scrollbarMode="showOnDemand" backgroundColor="menubackground" transparent="1" />
<widget name="detailslabel" position="22,140" size="850,800" font="menulist;34" itemHeight="50" foregroundColor="maincolour" backgroundColor="menubackground" halign="center" valign="center" transparent="1" /> <widget name="extralabel" position="22,140" size="850,850" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" transparent="1" />
<widget name="ratinglabel" position="22,900" size="850,50" font="menulist;34" foregroundColor="maincolour" backgroundColor="menubackground" transparent="1" halign="left" valign="center" zPosition="2" />
<widget name="starsbg" pixmap="imdb/starsbar_empty.png" position="22,950" size="315,32" backgroundColor="menubackground" transparent="1" alphatest="blend" zPosition="2" />
<widget name="stars" pixmap="imdb/starsbar_filled.png" position="22,950" size="315,32" backgroundColor="menubackground" transparent="1" alphatest="blend" zPosition="3" />
<widget name="poster" position="1250,600" size="335,377" alphatest="blend" zPosition="2" />
<panel name="ButtonBar" />
</screen>
smipx
07-04-20, 17:20
ie. like this:

59852