Bug in EPG screen when adding a recording

[smipx]

Hi,

I wanted to report an "odd behaviour" in the EPG. when you do a +24 several times to get, say 4 days hence, and find a program you want to record. After setting the recording (either Autotimer or single record) the EPG jumps back to the current day/time. this means that you cannot immediately see if the recording has taken and more importantly you cannot carry on from that point and select further items to record without having to do a lot of keypresses to get back to 4 days hence (e.g. you may be going through the whole week to select recordings and this jumping back to the present day/time means that it is a much bigger chore with many more key presses than it needs to be).

I have tested this in OpenATV and on that image when you do this the EPG stays at the 4 days hence position so you can just carry on quickly and efficiently.

Is this a bug?

I am using KiddaC Slyk Onyx skin with his enigma2-plugin-extensions-openvix-epgselection-mod_2.0_all.ipk package however - it seems to do this even with this removed and using the default skin.

thanks
Paul

[smipx]

Sorry. Appears that the KiddaC mod may be the cause. Please disregard this post for now and my apologies for wasting time.

[abu baniaz]

I have already posted on the other two fora you have raised this that the official file does not have this. As you are a python programmer, best you add the hacks to the latest official file. bbbuk's fork may be nearest to the official one.



However, some work has been done to make the files modular and remove the spaghetti. We have not implemented or agreed how to test it yet.

[smipx]

Hi, I am not a programmer myself so I assume that was directed at KiddaC ?

I have reverted to the original EpgSelection.py
I then ran a system update and rebooted

I then went into the EPG and went ahead a few days. I selected a program to record and I'm happy to report that it now works.

What would be really nice would be to have the ability to assign +24 and -24 hours to the buttons (like in KiddaC's mod) and then have the two recording options and IMDB search under one of the other buttons. It seems a lot more logical that way. It would also mean that KiddaC would not need to maintain the mod. I can live with the terminology of "Autotimer" rather than "Series link" but the other mods do seem to make a lot of sense.

Just saying :-)
what do you think?

thanks
Paul

[smipx]

I have already posted on the other two fora you have raised this that the official file does not have this. As you are a python programmer, best you add the hacks to the latest official file. bbbuk's fork may be nearest to the official one.



However, some work has been done to make the files modular and remove the spaghetti. We have not implemented or agreed how to test it yet.

Hi, I am not a programmer myself so I assume that was directed at KiddaC ?

I have reverted to the original EpgSelection.py
I then ran a system update and rebooted

I then went into the EPG and went ahead a few days. I selected a program to record and I'm happy to report that it now works.

What would be really nice would be to have the ability to assign +24 and -24 hours to the buttons (like in KiddaC's mod) and then have the two recording options and IMDB search under one of the other buttons. It seems a lot more logical that way. It would also mean that KiddaC would not need to maintain the mod. I can live with the terminology of "Autotimer" rather than "Series link" but the other mods do seem to make a lot of sense.

Just saying :-)
what do you think?

thanks
Paul

[ccs]

I've found that setting ordinary timers doesn't skip back.

TIP: when setting an autotimer, select the program in question, press yellow to do an epg search, and setup the autotimer from there.

Exit takes you back to where you were in the epg.:)

[smipx]

Hi ccs,

With KiddaC's mod?

[ccs]

Hi ccs,

With KiddaC's mod?

Sorry, probably misread the thread, this certainly works with the "standard" ViX implementation.

[smipx]

Sorry, probably misread the thread, this certainly works with the "standard" ViX implementation.
No Worries mate :-)

[Willo3092]

Inserting self.getCurrentCursorLocation = self['list'].getCurrentCursorLocation() after line 839 seems to work.

[smipx]

Thanks Willo3092.

Sadly it looks like KiddaC is no longer actively maintaining the EPG mod as he is a busy man and has moved on to other projects so we will all have to make out own tweaks going forward by the looks of it :-(
He explains this in his skin thread here: https://www.linuxsat-support.com/thread/134771-skin-support-post-questions-for-all-my-skins-in-here/?postID=535634#post535634

Cheers,
Paul

[Willo3092]

This is in the standard ViX epgselection, not KiddaC's version.

[smipx]

Ahh. Understood :-)

I guess one could hunt for that line of code in his mod and tweak it too

Paul

[smipx]

Hi Willo3092

Just to confirm. Is it in this line it needs to be inserted. (Just checking I have the right epgselection.py)

def eventViewCallback(self, setEvent, setService, val):
l = self['list']
old = l.getCurrent()
if self.type == EPG_TYPE_GRAPH or self.type == EPG_TYPE_INFOBARGRAPH:
self.updEvent(val, False)
elif val == -1:
self.moveUp()
elif val == +1:
self.moveDown()
cur = l.getCurrent()
if (self.type == EPG_TYPE_MULTI or self.type == EPG_TYPE_GRAPH or self.type == EPG_TYPE_INFOBARGRAPH) and cur[0] is None and cur[1].ref != old[1].ref:
self.eventViewCallback(setEvent, setService, val)
>>>> Insert Here?????
else:
setService(cur[1])
setEvent(cur[0])

[Willo3092]

I don't know, I'm at work now. It's just the standard epgselection with OpenViX. I just pressed return after line 839 and pasted it in.

[smipx]

:-) No rush at all mate. When you next have the file open if you could let me know. Don't want to F it all up.

[Willo3092]

Just save the original epgselection.py and overwrite it if it goes wrong.
The line in green is the one I added

59758

[smipx]

:-)

Glad I asked as my positioning was off
thanks for that.
I tried finding the same piece of code in KiddaC's modified code and further modified it but it didn't work sadly (just in case anyone reads this and thought to have a go - I can save you the bother).

Thanks
Paul

[abu baniaz]

My mistake, I can confirm the bug. However, the change suggested by willow does not fix it.

[smipx]

Hi Abu, if and when it does get fixed I would love to know what code changes were made. That way I can retro-fit the code changes to KiddaC mod.

cheers,
Paul

[abu baniaz]

My preferred option is to make the file easier to read/edit/fix then fix the bug.

It may be prudent for you to look at the existing thread for the modification.
https://www.world-of-satellite.com/showthread.php?42788-Some-ideas-to-improve-the-Graphical-EPG-screen

Will also be easier for you to set auto timers using Single EPG. Just press the Red button.

[smipx]

:-) I have put my requests in that post (for them to be turned down possibly - but I can only ask). As an end user (rather than a developer) those are the options that would make the system much more usable for my (having come from freesat/sky) and using this as a replacement.

[Willo3092]

My mistake, I can confirm the bug. However, the change suggested by willow does not fix it.

The attached epgselection.py is working for me, as far as setting the epg to go back to the previous screen rather than the current day/time.
I have swapped the 2&8 buttons with CH+/- so that the channel buttons are for going up and down a page in the epg.... and done some cosmetic renaming.
Maybe someone can try it?

[smipx]

The Wife's watching the TV at the moment (under OpenATV as the KiddaC mod is working on that build so I have settled on that build for now) but when I get a chance I will multiboot over to OpenVIX and test it :-)
for me personally - the real need (desire) is the +24 and -24 hours in the EPG :-)

It seems to me that there are a number of people who would like different functions on the buttons and the "best" thing is for the VIX team to make it more configurable. I think there is a way in the setup however it looks like the options are quite limited (e.g. no +24hrs, -24hrs). I guess I am only looking at things from a very narrow perspective and so there may well be some good reasons for this not to happen - what do I know - ha ha!

[Willo3092]

All the changes I've been faffing with are driven by Mrs Willo :rolleyes:
She wants to be able to use CH+/- to change pages in the epg and to have a clear idea of what to press if she wants to record anything. 'Add timer' means nothing to her!
Obviously because I have put page up and down on the channel keys I have had to put +/- 24 hours on the 2 & 8 buttons.

[smipx]

Sorry I mis-understood I think. So by default are the Ch+ and Ch- buttons +24hrs and -24hrs then? and in your mod these are now page down/page up and 2 & 8 are now +24 -24?

Where the heck is all of this documented (I don't mean your mods above I mean the standard functionality). Is there a guide somewhere?

Cheers,
Paul

[ccs]

Ch+ and Ch- are +24hrs and -24hrs in the standard ViX implentation.

I use a Harmony remote to get round any other "deficiencies". :)

[smipx]

I wished I 'd known that before - I am kicking myself now. I use a All-for-one remote but have run out of buttons a bit (hense my slight obsession with the coloured buttons) :-(
Now --- If I could get the BBC old fashioned TXT button to work that would be awsome but I am guessing that its a hardware driven thing. It's definitely there somewhere in the transmission signal as it works on both Freeview and on freesat - On my TV and on my freesat box I can press TXT and it brings up the BBC text service (you know - the one they were due to stop but have since given a reprieve) and of course having the BBC red button would be just too much to ask.

The wife can't cope with buttons not doing what they say on the label - I would tell her that 2 & 8 are for +24 etc. It would then be totally forgotten a day later. However.... I have a chance with telling her that CH+ and CH- are in fact +24 and -24 :-)

[Joe_90]

For info - the old teletext/Ceefax are normally carried as MHEG on digital transmissions. MHEG is subject to licence, so is not present on enigma receivers, but is available on Freesat/Freeview licensed receivers and TVs. The TXT button normally pulls up an on-screen keyboard on enigma.

[smipx]

Hi fat-tony re: MHEG - that puts that one to bed then. Thanks for the info. So much to learn - so little time ........

[bbbuk]

Attached is latest version of epg mod I'm currently using.

It's built to take into account changes for Vix 5.3 018.

You are expected to have some skills with finding and replacing existing files that this mod replaces and how-to do this (eg using FileZilla, etc)

Thanks to those that were involved in it's original creation and those currently keeping this alive/maintained.

Disclaimer:
Ensure you make a full image back-up first
Obviously, no official support from vix, myself or anyone else that had input into epg mod
This doesn't have tabbed EPG as used by kiddac skins
This isn't maintained by me so no asking "can you add..."
Use as is and at own risk
Should still be considered beta as not everything may have been tested

[smipx]

The attached epgselection.py is working for me, as far as setting the epg to go back to the previous screen rather than the current day/time.
I have swapped the 2&8 buttons with CH+/- so that the channel buttons are for going up and down a page in the epg.... and done some cosmetic renaming.
Maybe someone can try it?

Hi Willo3092,

Finally got to test this and I can confirm that it DOES remember the position of the EPG after adding an AutoTimer recording. :-)

Can I just check. Was the only change (to make that part work) the one you mentioned above i.e. The one line at 840?
If so then I must have not made the change myself correctly as when I tried that it did not fix it.

Cheers,
Paul

[smipx]

Hi Willo3092,

Finally got to test this and I can confirm that it DOES remember the position of the EPG after adding an AutoTimer recording. :-)

Can I just check. Was the only change (to make that part work) the one you mentioned above i.e. The one line at 840?
If so then I must have not made the change myself correctly as when I tried that it did not fix it.

Cheers,
Paul

If it is the only line of code change then annoyingly I tried to make the same line addition in Kiddac's version of the file and it didn't work (boo hiss). The only reason I wanted to try that is because his implementation shows the bouquet you are in at the top of the EPG screen and none of the other versions (default, your's or bbbuk's) show these. I am sure there is a way to know which Bouquet you are currently in (without the need to have the extra "select your Bouquet" screen at the beginning so I am probably missing something there.

59780

Cheers,
Paul

[ccs]

Maybe this guide will help....

https://www.world-of-satellite.com/showthread.php?51808-EPG-Channels-and-Bouquets&p=375531&viewfull=1#post375531

[smipx]

Hi ccs. Very helpful. Thanks for that.
Paul

[birdman]

I am sure there is a way to know which Bouquet you are currently in (without the need to have the extra "select your Bouquet" screen at the beginning so I am probably missing something there.My EPG screen (the standard Vix one) has the current bouquet showing at the top left (two different skins checked).

[smipx]

Hi Birdman,

You are completely correct. I was using the KiddaC Onyx skin and it was not in there (as of couse that skin has the tabs instead). I have now switched over to a fully supported (and I assume maintained) skin that I downloaded from the plugins section and plan to use that (or one of those) going forward. I am currently using the Blue HD skin and quite like it. In that skin it does indeed show the Bouquet in the top left.

I am sad as I liked onyx but....... Maintenance is everything and KiddaC has moved on to other projects so it may not be as "maintained" as needed. I have succumbed to the pressure :-) I was fighting a losing battle.

On the subject of skins...... Which ones are "fully maintained" and "compliant" with the current and future builds of openVIX? Is it only the ones that are in the plugins download section? What about the Chabs skins for example?

Thanks again,
Paul

[smipx]

Attached is latest version of epg mod I'm currently using.

It's built to take into account changes for Vix 5.3 018.

You are expected to have some skills with finding and replacing existing files that this mod replaces and how-to do this (eg using FileZilla, etc)

Thanks to those that were involved in it's original creation and those currently keeping this alive/maintained.

Disclaimer:
Ensure you make a full image back-up first
Obviously, no official support from vix, myself or anyone else that had input into epg mod
This doesn't have tabbed EPG as used by kiddac skins
This isn't maintained by me so no asking "can you add..."
Use as is and at own risk
Should still be considered beta as not everything may have been tested

Hi bbbuk, Just an FYI. I also tested Willo's "self.getCurrentCursorLocation = self['list'].getCurrentCursorLocation()" fix in your mod files and am happy to report that it fixes the jumping back on Autotimer set in your mods too :-)

[smipx]

On a related query Are these things here because I have a padding set?

59781

If so is it possible to remove them and if so what bit of the code might it be located in?

Cheers
Paul

[Andy_Hazza]

They are shown as part of your main recordings, so records a bit before, then records your main slot and records a bit after, simply to make sure your main recording is preserved.


Sent from my iPhone using Tapatalk

[smipx]

Hi,

Thought so :-)

[bbbuk]

Hi bbbuk, Just an FYI. I also tested Willo's "self.getCurrentCursorLocation = self['list'].getCurrentCursorLocation()" fix in your mod files and am happy to report that it fixes the jumping back on Autotimer set in your mods too :-)Thanks. Which file and where about does this go and I'll add it :)

[smipx]

Hi,

Its in epgselection.py you need to search for this section and add the line at the end of the section just like this:

59783

[Willo3092]

This is the epgselection from ViX 5.3.018 with the autotimer fix. Nothing else has been altered.

59784

59785

[slimgym]

Apologies if this is what has already been achieved above. I'm not a programmer but did my best to try and understand what it was trying to do, grabbed a fresh copy of EpgSelection.py from kiddac's Dropbox extras and and apparently now have both tabbed Slyk Q epg and the jump problem on set recordings resolved.

First I did the above modifications "self.getCurrentCursorLocation = self['list'].getCurrentCursorLocation()"

Then within def onCreate(self) I added the second line to match:
if self.type == EPG_TYPE_GRAPH or self.type == EPG_TYPE_INFOBARGRAPH:
self.getCurrentCursorLocation = None

Within def addAutoTimer(self), def addAutoTimerSilent(self) insert this line after "self.refreshTimer.start(3000)" (2 occurrences)
self.getCurrentCursorLocation = self['list'].getCurrentCursorLocation()

Within def removeTimer(self, timer), def disableTimer(self, timer), def finishedAdd(self, answer) insert this line before self.refreshlist() (3 occurrences)
self.getCurrentCursorLocation = self['list'].getCurrentCursorLocation()

Reboot machine and following this it all seems to work. Obviously I would make a copy of the existing Epgselection.py before changing so you can put it back if it messes up and no guarantees ;)

59839

[Willo3092]

Apologies if this is what has already been achieved above. I'm not a programmer but did my best to try and understand what it was trying to do, grabbed a fresh copy of EpgSelection.py from kiddac's Dropbox extras and and apparently now have both tabbed Slyk Q epg and the jump problem on set recordings resolved.

First I did the above modifications "self.getCurrentCursorLocation = self['list'].getCurrentCursorLocation()"

Then within def onCreate(self) I added the second line to match:
if self.type == EPG_TYPE_GRAPH or self.type == EPG_TYPE_INFOBARGRAPH:
self.getCurrentCursorLocation = None

Within def addAutoTimer(self), def addAutoTimerSilent(self) insert this line after "self.refreshTimer.start(3000)" (2 occurrences)
self.getCurrentCursorLocation = self['list'].getCurrentCursorLocation()

Within def removeTimer(self, timer), def disableTimer(self, timer), def finishedAdd(self, answer) insert this line before self.refreshlist() (3 occurrences)
self.getCurrentCursorLocation = self['list'].getCurrentCursorLocation()

Reboot machine and following this it all seems to work. Obviously I would make a copy of the existing Epgselection.py before changing so you can put it back if it messes up and no guarantees ;)

59839

Are you using KiddaC's file on ViX or ATV?
I've just tried the above mod on the ViX version and it just bootloops on my box.
If you're using ViX can you upload the epgselection.py please. I may have cocked something up :eek:

[slimgym]

VIX 5.3.019 Zgemma H7S

Is it boot looping the OS or just the GUI? (obviously if the latter replace the previous /usr/lib/enigma2/python/Screens/EpgSelection.py)

I just diff checked the one downloaded from here and it's the same as the one running on my box.

[Willo3092]

Sorry, didn't notice you'd already uploaded the py file. I'll try it later thanks :thumbsup:

[Willo3092]

Yes that works mate :thumbsup:
Well it does now I've added the skin_user.xml with the option button and epg tabs :rolleyes:

59841

[slimgym]

Cool, good to hear! Glad thats resolved was really bugging me.

59842